Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review makefile to build SPK #34

Open
jdel opened this issue Feb 27, 2017 · 2 comments
Open

Review makefile to build SPK #34

jdel opened this issue Feb 27, 2017 · 2 comments

Comments

@jdel
Copy link
Owner

jdel commented Feb 27, 2017

make spk should be working but the postinstall script needs to be reviewed to get composer and install dependencies.

Travis is probably going to fail builds after this...

@jdel
Copy link
Owner Author

jdel commented Feb 27, 2017

Also add a test rule so travis can run the tests for us

@mbirth
Copy link
Collaborator

mbirth commented Feb 28, 2017

Composer needs the phar extension to be installed/enabled for the used php version. Can be checked with (5.6 has it enabled, 7.0 not):

# php56 -i | grep Phar
Phar
Phar: PHP Archive support => enabled
Phar EXT version => 2.0.2
Phar API version => 1.1.1
Phar-based phar archives => enabled
Phar based on pear/PHP_Archive, original concept by Davey Shafik.
Phar fully realized by Gregory Beaver and Marcus Boerger.

# php70 -i | grep Phar
#

There seems to be no easy way to enable already installed (but disabled) extensions. (Would have to fiddle with e.g. /volume1/@appstore/PHP5.6/usr/local/etc/php56/conf.d/extensions.ini) So it's probably better to show an error or a warning or just let postinst fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants