Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

going back to qunit often gets the theme wrong #15

Open
jdee opened this issue Nov 11, 2010 · 2 comments
Open

going back to qunit often gets the theme wrong #15

jdee opened this issue Nov 11, 2010 · 2 comments

Comments

@jdee
Copy link
Owner

jdee commented Nov 11, 2010

If you visit the qunit test page, then go home by clicking on the Dubsar Project banner, then click the back button, the Dubsar Project banner will always appear orange (dark theme). From there, if you go back to the main Dubsar site, the theme will always be set to dark, regardless how it was set before you visited the qunit page.

@jdee
Copy link
Owner Author

jdee commented Nov 11, 2010

In general, on the whole site, going back tends to ignore your cookie setting and simply show the markup in the style originally rendered by the server. That is, if you view the page source, the class on the body element will match the style you are seeing, even if you changed it using the theme picker. This doesn't explain the QUnit issue, though it might be related, and it's part of the general back issue.

@jdee
Copy link
Owner Author

jdee commented Nov 12, 2010

The qunit-specific behavior has been fixed. Now you can go from the main site to the tests, hit back twice and get the correct display theme back after execution of the test suite. But the general problem of getting the theme right on back after a change remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant