Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing typescript overload for Issues.all({ showExpanded: true, withLabelDetails: true }) #3633

Closed
2 tasks done
kouak opened this issue Sep 30, 2024 · 1 comment · Fixed by #3640
Closed
2 tasks done

Missing typescript overload for Issues.all({ showExpanded: true, withLabelDetails: true }) #3633

kouak opened this issue Sep 30, 2024 · 1 comment · Fixed by #3640
Labels
released This issue/pull request has been released. type:types Adding or enhancing typescript types

Comments

@kouak
Copy link
Contributor

kouak commented Sep 30, 2024 •
edited
Loading

Description

  • Node.js version: 22.8.0
  • Gitbeaker version: 40.3.0
  • Gitbeaker release (cli, rest, core, requester-utils): rest
  • OS & version: Linux

Basically, a missing overload/case regarding Issues.all().

image

Steps to reproduce

      const issues = await gitlab.Issues.all({
        projectId: 1,
        withLabelsDetails: true,
        showExpanded: true,
      });

Expected behaviour

issues should be { paginationInfo: OffsetPagination, data: IssueSchemaWithExpandedLabels[] }

Checklist

  • I have checked that this is not a duplicate issue.
  • I have read the documentation.
@jdalrymple jdalrymple added the type:types Adding or enhancing typescript types label Oct 1, 2024
@jdalrymple jdalrymple mentioned this issue Oct 16, 2024
Merged
@jdalrymple
Copy link
Owner

🚀 Issue was released in 40.6.0 🚀

@jdalrymple jdalrymple added the released This issue/pull request has been released. label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released This issue/pull request has been released. type:types Adding or enhancing typescript types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating missing expanded types for Issues.all jdalrymple/gitbeaker
2 participants
@kouak @jdalrymple