Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace <= and >= #21

Open
jejay opened this issue Jun 22, 2013 · 1 comment
Open

Replace <= and >= #21

jejay opened this issue Jun 22, 2013 · 1 comment

Comments

@jejay
Copy link

jejay commented Jun 22, 2013

Please replace all existing <= and >= with Sylvester.precision based operations such as

function leql(operand1, operand2) {
    return (operand1 < operand2) || eql(operand1, operand2);
}

for <=, which would probably solve #6 and other imaginable issues.

@jcoglan
Copy link
Owner

jcoglan commented Jun 23, 2013

This is quite likely to lead to large performance degradations. Sylvester avoids function calls where possible; if you read the source you'll see that a lot of functions that could be implemented in terms of others are actually implemented with all the maths inline. This is because function calls are expensive and removing them lead to large performance gains.

Do you have any code examples to demonstrate how this would solve #6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants