Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommitsComparison.smart.files() should return collection of structured objects #1082

Closed
cvrebert opened this issue May 16, 2015 · 3 comments
Closed

CommitsComparison.smart.files() should return collection of structured objects #1082

cvrebert opened this issue May 16, 2015 · 3 comments
Labels
30 mins bug DEV

Comments

@cvrebert
Copy link
Contributor

Right now, it just returns a raw JsonArray. This is not typesafe and is inconvenient to work with.
(Probably needs a class like egit-github's CommitFile)
@cvrebert cvrebert mentioned this issue May 16, 2015
Open
@yegor256 yegor256 added the bug label May 24, 2015
@dmarkov
Copy link

dmarkov commented May 25, 2015

@cvrebert this task will get someone's attention soon

@cvrebert
Copy link
Contributor Author

cvrebert commented Jun 3, 2015

@dmarkov Please roughly define "soon". Days? Weeks? Months?

@cvrebert cvrebert mentioned this issue Jun 12, 2015
Merged
@dmarkov
Copy link

dmarkov commented Jun 17, 2015

@rultor rultor closed it (automatically), @cvrebert please take a look

@dmarkov dmarkov reopened this Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
30 mins bug DEV
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cvrebert @yegor256 @dmarkov