Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command/whitelist service #120

Open
xstefank opened this issue Apr 3, 2020 · 5 comments
Open

Add command/whitelist service #120

xstefank opened this issue Apr 3, 2020 · 5 comments
Assignees

Comments

@xstefank
Copy link
Member

xstefank commented Apr 3, 2020

Processes the commands from PRs/issues. Runs the CI/whitelisting if necessary.

@lukasburda
Copy link
Contributor

Can I start working on this?

@lukasburda
Copy link
Contributor

Is it still relevant?

@xstefank
Copy link
Member Author

@lukasburda I wouldn't mind splitting the tyr-core functionality into two modules. tyr-core would be just PR checks and a new tyr-ci module would be for whitelisting. Do you want to try this?

@lukasburda
Copy link
Contributor

lukasburda commented Feb 22, 2021

@xstefank maybe it would be better to separate the whitelisting from TemplateChecker class and create quarkus module where you start only the whitelist service. Maybe then Issue #119 would not be relevant because tyr-webhook will be just for checks. What do you think?

@xstefank
Copy link
Member Author

@lukasburda it's a good idea but don't create a new module, you can expose the whitelisting in the tyr-webhook for now. If there will be a requirement for a CLI then we will create a new module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants