You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently all Aphrodite methods are exposed by an Aphrodite instance, this is simple for the user, however this has resulted in Aphrodite.java becoming increasingly bloated.
It could be advantageous to split Aphrodite's interface into multiple sub-managers. For example we could have:
Aphroditeaphrodite = Aphrodite.instance()
IssueTrackerManagerisManager = aphrodite.getIssueTrackerManager();
isManager.searchIssues(...);
RepositoryManagerrepoManager = aphrodite.getRepositoryManager();
repoManager.getPatchesAssociatedWith(...);
...
// Apply to Stream Services as well
Utilising Manager classes in this way, would also allow additional features to be added without further polluting Aphrodite.java. For example, each individual 'Manager' class could expose additional options, such as getIssueTrackerByHost() etc which would allow applications to utilise individual instances of IssueTrackers directly.
The text was updated successfully, but these errors were encountered:
I think is better to keep calls like getIssueTrackerByHost() in aphrodite and return some sort of CompositeIssueTrackerService (implementing the IssueTrackerService) than creating a new class like a manager. This way we are always working with the service interfaces.
Currently all Aphrodite methods are exposed by an Aphrodite instance, this is simple for the user, however this has resulted in Aphrodite.java becoming increasingly bloated.
It could be advantageous to split Aphrodite's interface into multiple sub-managers. For example we could have:
Utilising Manager classes in this way, would also allow additional features to be added without further polluting Aphrodite.java. For example, each individual 'Manager' class could expose additional options, such as getIssueTrackerByHost() etc which would allow applications to utilise individual instances of IssueTrackers directly.
The text was updated successfully, but these errors were encountered: