Add ClusterSeries to Hero Series Types #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suport MultiIndex as function parameter returns MultiIndex, where Representation was returned * missing: correct test Co-authored-by: Henri Froese <[email protected]>
*missing: test adopting for new types Co-authored-by: Henri Froese <[email protected]>
- add functionality for decorator @InputSeries to handle several allowed input types - Add typing decorator/hints to representation.py - add tests for _types DocumentTermDF Co-authored-by: Maximilian Krahn <[email protected]>
Co-authored-by: Maximilian Krahn <[email protected]>
|
Note: Black (our formatter) just rolled out V20.8b1 3 days ago. This creates errors with our ./tests.sh in preprocessing because of whitespace. Will investigate this further but atm we set the black version in EDIT: found the issue, see the issue opened at Black here |
This was referenced Aug 29, 2020
|
Merged master branch into this one, so it is ready for review/to be merged 🦂 🐼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that with topic modelling etc. coming up, we get more and more use out of the clustering functions. It thus makes sense to introduce a
HeroSeriestypeClusterSeriesthrough this PR.A ClusterSeries has dtype "category" and every entry is a cluster-ID (e.g. 5 or "topic 1"). For example,
pd.Series([0, 3, 0, 1], dtype="category")is a valid ClusterSeries.NOTE: only so many commits/lines as this builds on #157