Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release with support for Django 2.1 #203

Closed
ferndot opened this issue Aug 1, 2018 · 8 comments
Closed

Release with support for Django 2.1 #203

ferndot opened this issue Aug 1, 2018 · 8 comments
Labels

Comments

@ferndot
Copy link

ferndot commented Aug 1, 2018

This package breaks on Django 2.1 due to a Django API change. I reproduced this issue using both the PyPi version and the master branch.

Here is the error I receive:

Traceback (most recent call last):
web_1       |   File "./manage.py", line 10, in <module>
web_1       |     from configurations.management import execute_from_command_line
web_1       |   File "/usr/local/lib/python3.7/site-packages/configurations/management.py", line 3, in <module>
web_1       |     importer.install(check_options=True)
web_1       |   File "/usr/local/lib/python3.7/site-packages/configurations/importer.py", line 49, in install
web_1       |     importer = ConfigurationImporter(check_options=check_options)
web_1       |   File "/usr/local/lib/python3.7/site-packages/configurations/importer.py", line 67, in __init__
web_1       |     self.check_options()
web_1       |   File "/usr/local/lib/python3.7/site-packages/configurations/importer.py", line 87, in check_options
web_1       |     add_help=False)
web_1       | TypeError: __init__() takes 1 positional argument but 2 were given
@blueyed blueyed mentioned this issue Aug 1, 2018
1 task
@blueyed
Copy link
Contributor

blueyed commented Aug 1, 2018

Looks like it should be fixed in d3b9931.

@bryson
Copy link

bryson commented Aug 2, 2018

When will a new PyPI release be created that includes this?

@blueyed
Copy link
Contributor

blueyed commented Aug 2, 2018

See also #195 (for 2.0, which worked for me so far).

I've merged #201 already.

Somebody writing the changelog would help certainly.

@blueyed blueyed changed the title This does not support Django 2.1 Release with support for Django 2.1 Aug 2, 2018
@blueyed blueyed added the bug label Aug 2, 2018
@blueyed
Copy link
Contributor

blueyed commented Aug 3, 2018

Also confirmation that master actually works for you with dj21 would be helpful, too.

@moorchegue
Copy link

moorchegue commented Aug 8, 2018

I've tried 2.1 with current master and can confirm that the problem is gone.

Please release :)

@drewbrew
Copy link
Contributor

@blueyed cherry-picked my commit from #206 and tagged the new release. As soon as 2.1 goes live on PyPI, this should be good to be closed.

@blueyed
Copy link
Contributor

blueyed commented Aug 16, 2018

Released it now.
Thanks for the changelog, @drewbrew!

@blueyed blueyed closed this as completed Aug 16, 2018
@drewbrew
Copy link
Contributor

Glad to help. I'll be using this code in my example project in my DRF talk during DjangoCon US 2018, so I figured I might as well make sure all my dependencies are as up to date as possible. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants