Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on django-crispy-forms #343

Closed
pydanny opened this issue Jul 18, 2013 · 2 comments
Closed

Remove dependency on django-crispy-forms #343

pydanny opened this issue Jul 18, 2013 · 2 comments
Assignees
Milestone

Comments

@pydanny
Copy link
Member

pydanny commented Jul 18, 2013

As much as I like the library, I'm unhappy with it's presence. This is because it removes from us the easy ability to more readily create custom features like the readonly_fields attribute without even more hacking on form objects. In fact, all we use it for is simple rendering of the form in templates, which isn't enough.

Tasks:

  • Remove from dependency list
  • Remove from INSTALLED_APPS.
  • Create an includes/form.html template that renders forms.
@pydanny
Copy link
Member Author

pydanny commented Jul 18, 2013

Thanks to #333 crispy_forms is only necessary for the default theme. Whew!

@auvipy
Copy link
Contributor

auvipy commented Jun 12, 2016

fixed

@auvipy auvipy closed this as completed Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants