Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default theme to it's own installable app #333

Closed
pydanny opened this issue Jul 14, 2013 · 3 comments
Closed

Move default theme to it's own installable app #333

pydanny opened this issue Jul 14, 2013 · 3 comments

Comments

@pydanny
Copy link
Member

pydanny commented Jul 14, 2013

I've realized the way we've implemented the default theme is problematic in that it doesn't follow the same installation pattern that other themes need to follow - specifically inclusion as a settings.INSTALLED_APP. This makes it really hard to use it as an theme-building example.

Perhaps move it to it's own app at:

  • djadmin2.themes
  • djadmin2.themes with it's own form display code so we can remove the dependency on crispy forms
  • Some other location in the django-admin2 repo
  • Another repo as it's own project?

Thoughts?

@pydanny
Copy link
Member Author

pydanny commented Jul 14, 2013

Sphinx comes with a bunch of default themes, which makes it really handy for developers who want to try different themes without installing a ton of unnecessary stuff. Maybe follow this pattern as well?

@pydanny
Copy link
Member Author

pydanny commented Jul 18, 2013

Hey @sehmaschine, this should make building themes much easier to comprehend. In the 0.7.0 milestone I want to focus on making theming easier. In 0.6.0 we are getting core logic in.

@sehmaschine
Copy link

@pydanny looking forward to 0.6.0/0.7.0 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants