Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py does not fallback to using distutils.core import setup #13

Closed
allanhaywood opened this issue Apr 18, 2017 · 2 comments · Fixed by #14
Closed

setup.py does not fallback to using distutils.core import setup #13

allanhaywood opened this issue Apr 18, 2017 · 2 comments · Fixed by #14

Comments

@allanhaywood
Copy link
Contributor

In all of the setup.py scripts I have used before, the import for setup is like this:

try:
from setuptools import setup
except ImportError:
from distutils.core import setup

Which allows it to fall back to distutils.core if setuptools is not available.

Is there a reason that this is missing from this projects setup.py?

Thanks.

@ncoghlan
Copy link
Collaborator

Only the fact that setup.py bdist_wheel only works with setuptools, and that was the original motivation for moving away from plain distutils.

I'd accept a PR to add the fallback, as the setup call itself doesn't rely on any setuptools features, so it should be enough to get setup.py install working again under plain distutils.

@allanhaywood
Copy link
Contributor Author

Thanks. I submitted a PR, let me know if there is anything additional needed on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants