Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SVG Icon Stacks #1

Open
andydavies opened this issue Jun 5, 2019 · 1 comment
Open

Support for SVG Icon Stacks #1

andydavies opened this issue Jun 5, 2019 · 1 comment

Comments

@andydavies
Copy link

Would you be up for a PR that adds support for SVG icon stacks - http://simurai.com/blog/2012/04/02/svg-stacks

I think it's a pretty simple change, still need to finish testing but query pattern becomes "svg > symbol[id], svg > svg[id]"

@jaydenseric
Copy link
Owner

If my very shallow understanding of SVG icon stacks is correct, then an icon could potentially be any element with an id attribute, such as <g>?

My concern is that lots of things have ids, including gradients, masks, groups, and paths. If all implementations have an icon class on icons, the selector can be a lot more robust.

If it can be done reliably a PR is welcome :) The results could be split into two subsections under separate headings, one for symbols and one for an icon stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants