Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: use this package without change old code #139

Closed
trim21 opened this issue Aug 28, 2024 · 1 comment
Closed

feature request: use this package without change old code #139

trim21 opened this issue Aug 28, 2024 · 1 comment

Comments

@trim21
Copy link

trim21 commented Aug 28, 2024

We want to try niquests in our code, but it will install urllib3.future and it will override some files from official urllib3 package. Which may cause some unexpected effect on our existing code.

Is there a way to use this package with requests, without interfering urllib3?

@Ousret
Copy link
Member

Ousret commented Aug 28, 2024

Unfortunately, at the time being, we cannot do this by default. For reasons explained in https://github.com/jawah/urllib3.future?tab=readme-ov-file#notes--frequently-asked-questions and https://niquests.readthedocs.io/en/latest/community/faq.html#what-is-urllib3-future and jawah/urllib3.future#91

Your options are as follow:

Finally, I would argue that:

  • urllib3-future has a better compatibility range than its predecessor (Python 3.7 and OpenSSL <1.1.1 supported)
  • urllib3-future is thoroughly tested against software than deeply interact with urllib3 internals https://github.com/jawah/urllib3.future/actions/runs/10463745326
  • urllib3-future solve issues in often less than 48 hours
  • urllib3 did break things several times like there, and it's not going to stop anytime soon with what is coming.

regards,

@Ousret Ousret closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants