Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonModelGen does not work with the latest gltf schema #4

Closed
kirillp opened this issue Dec 27, 2019 · 2 comments
Closed

JsonModelGen does not work with the latest gltf schema #4

kirillp opened this issue Dec 27, 2019 · 2 comments

Comments

@kirillp
Copy link

kirillp commented Dec 27, 2019

if I set urlString to latest glTF.schema.json the generator crashes with NPE.

The old urlString does not work either.

@javagl
Copy link
Owner

javagl commented Dec 30, 2019

As mentioned in the README: The generator is not really intended for public use, and very narrowly focused on generating the classes for glTF based on JSON schema 3. There also is a long-standing issue about updating the glTF JSON schema to a more recent version, at KhronosGroup/glTF#929 - the last comment talks about draft 7, but I'm admittedly not entirely up to date here.

However, of course it should be possible to use the generator as simply as possible (and of course, also for other JSON schemas beyond glTF, although this raises many, many questions about the desired degree of configurability). And of course, at the very least, it should support the current glTF schema, regardless of the version.

So I'll have a look at this ASAP.

@javagl
Copy link
Owner

javagl commented Jan 18, 2025

The latest changes added support for JSON schema 2020-12, which is currently used in glTF.

Specifically, I took care to make sure that the (newly introduced) JsonModelGenGltfCore class can be run on the current schema, and generate the expected output.

@javagl javagl closed this as completed Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants