Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for FragmentActivity #14

Closed
jeffwoooo opened this issue Sep 30, 2019 · 5 comments
Closed

support for FragmentActivity #14

jeffwoooo opened this issue Sep 30, 2019 · 5 comments

Comments

@jeffwoooo
Copy link
Contributor

I'm extending FlutterFragmentActivity rather than FlutterActivity for MainActivity.
And when an activity starts from fragment(not activity), request code should be in 0 ~ 65535.

So when I request phone number hint, it throws error because of the request code.

@alexviquez
Copy link

Did you find some solution about this?, i got the same problem as you

@jeffwoooo
Copy link
Contributor Author

Did you find some solution about this?, i got the same problem as you

I forked this repo and updated the request code. you can check it below.
jeffwoooo@9cd5f48

@jaumard
Copy link
Owner

jaumard commented Oct 24, 2019

If you can make a PR I'll gladly merge it :)

@jeffwoooo
Copy link
Contributor Author

Just made it, thanks!

@jaumard
Copy link
Owner

jaumard commented Oct 24, 2019

Deployed on 1.1.1 version :) thanks to you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants