Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to sublime-syntax #6

Closed
ehuss opened this issue Sep 27, 2017 · 2 comments · Fixed by #7
Closed

Update to sublime-syntax #6

ehuss opened this issue Sep 27, 2017 · 2 comments · Fixed by #7

Comments

@ehuss
Copy link
Collaborator

ehuss commented Sep 27, 2017

I'd like to fix some of the bugs in the TOML highlighting, and before doing that I think it would be nice if this was updated to sublime-syntax, possibly updated to conform with Sublime 3's scope naming rules, and include syntax tests.

@Jayflux I'd be happy to work on these changes. Would you be OK with a PR for this?

@jasonwilliams
Copy link
Owner

@ehuss absolutely
I was going to do it myself but ive completely ran out of time lately.

Thanks for picking this up

@ehuss ehuss mentioned this issue Oct 1, 2017
@ehuss
Copy link
Collaborator Author

ehuss commented Oct 1, 2017

I hope it's the good kind of busy and not the annoying kind.

I just opened a PR with the changes. No rush to look at it, of course. I broke it up into separate commits to maybe make it easier to see the individual changes. There are a lot of judgement calls for things like scope naming and how aggressive to be with error highlighting. Feel free to send me whatever feedback or questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants