-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code splitting support #42
Comments
important caveat - Rollup does not have code splitting support for UMD builds, which somewhat complicates things. so may just need to not offer UMD for code splitting builds. is this a dealbreaker? |
further investigation: using code splitting means we have random named chunks, and i get |
I need to read more about Rollup code splitting as I don’t understand how it would be beneficial for a library |
I will fix size snapshot when I will have a time. |
I just skimmed the docs. @sw-yx Can you elaborate more on the use case? I don't really understand why you want to code split identity widget itself in the first place. Instead, it makes more sense to just show consumers how to code split the the entire login route / modal? |
yeah. i withdraw my stupid idea. :) thanks for humoring me |
Code-splitting is currently supported by #367 |
Current Behavior
currently we bundle single files, named per environment/module format.
to support code splitting (which is the default behavior of Rollup v1 which we just upgraded to) we'll have to evolve this to a folder format with multiple files.
right now this https://github.com/sw-yx/react-netlify-identity-widget/blob/master/src/index.tsx#L8 doesnt produce a separate bundle for me :(
Desired Behavior
code splitting support.
Suggested Solution
as above
Who does this impact? Who is this for?
all users, partiuclarly React users, who want to offer code splitting as a feature
Describe alternatives you've considered
no change
Additional context
i'm unsure what existing priorities this may conflict with for you.
The text was updated successfully, but these errors were encountered: