Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSDX uses node_modules/tsdx/node_modules/typescript, rather than the package version #1044

Closed
colemars opened this issue Jun 11, 2021 · 1 comment
Labels
problem: removed issue template OP removed the issue template without good cause scope: dependencies Pull requests that update a dependency file solution: duplicate This issue or pull request already exists solution: intended behavior This is not a bug and is expected behavior solution: workaround available There is a workaround available for this issue

Comments

@colemars
Copy link

colemars commented Jun 11, 2021

This leads to some wonky build errors when there are some types relying on more recent ts functionality.

{
    "node_modules/tsdx/node_modules/typescript": {
      "version": "3.9.9",
      "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.9.tgz",
      "integrity": "sha512-kdMjTiekY+z/ubJCATUPlRDl39vXYiMV9iyeMuEuXZh2we6zz80uovNN2WlAxmmdE/Z/YQe+EbOEXB5RHEED3w==",
      "dev": true,
      "bin": {
        "tsc": "bin/tsc",
        "tsserver": "bin/tsserver"
      },
      "engines": {
        "node": ">=4.2.0"
      }
    },
}

A work around is to specify:

  "resolutions": {
    "typescript": "4.3.2" // your ts version
  }

in your package.json, however, this seems less than ideal.

@agilgur5 agilgur5 changed the title When building, tsdx uses "node_modules/tsdx/node_modules/typescript" version of typescript, rather than the package version. TSDX uses node_modules/tsdx/node_modules/typescript, rather than the package version Apr 11, 2022
@agilgur5 agilgur5 added solution: duplicate This issue or pull request already exists problem: removed issue template OP removed the issue template without good cause solution: workaround available There is a workaround available for this issue scope: dependencies Pull requests that update a dependency file solution: intended behavior This is not a bug and is expected behavior labels Apr 11, 2022
@agilgur5
Copy link
Collaborator

I think my answer in #1121 (comment) would answer this as well. Per my comment there, unfortunately it's much easier said than done to do this because of how many of TSDX's deps depend on TS.

Repository owner locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
problem: removed issue template OP removed the issue template without good cause scope: dependencies Pull requests that update a dependency file solution: duplicate This issue or pull request already exists solution: intended behavior This is not a bug and is expected behavior solution: workaround available There is a workaround available for this issue
Projects
None yet
Development

No branches or pull requests

2 participants