-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not initialize session if uneeded. helps express-session not create ... #320
do not initialize session if uneeded. helps express-session not create ... #320
Conversation
…e sessions when using saveUninitialized: false option
Sure hope this makes it into master. |
👍 |
Looks good. |
Thank you @ashelley , this will solve the problem that I have. |
+bazillion |
Our mongostore is highly interested in whether this PR has landed. Any updates? |
Good friends with write access, please merge this in when you can. |
There is anybody here? please, someone merge this ): |
I packaged up my solution to this problem, it is a hack, but it does the trick: https://github.com/wesleytodd/express-session-passport-cleanup I will maintain this at least until this gets merged if anyone wants to use it. |
Googlebot create thousands of sessions because of the related issue. I had to filter crawlers by user agent. Please, merge this pull request. |
@jaredhanson Any update on this? |
Merged. Published to npm as passport 0.3.0. Thanks! |
Thanks @jaredhanson |
...sessions when using saveUninitialized: false option
passport creates an empty passport object {} on req.session every request. this causes express-session saveUninitialized: false not to work properly. this patch may have implications for downstream strategies but i've fixed up the tests on passport core to make sure the session is not defined instead of {}.
Please review this for inclusion as it solves:
#259