Upgrade oauth dependency #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly for ciaranj/node-oauth#363, which fixes jaredhanson/passport-oauth2#163. I haven't been able to reproduce that issue with passport-oauth1, but in theory it may be possible. I'm not aware of any breaking changes in `oauth`. See https://github.com/ciaranj/node-oauth/commits
gabegorelick
commented
Oct 18, 2024
| @@ -1,156 +1,224 @@ | |||
| { | |||
| "name": "passport-oauth1", | |||
| "version": "1.3.0", | |||
| "lockfileVersion": 1, | |||
| "lockfileVersion": 3, | |||
There was a problem hiding this comment.
I could downgrade my npm if we want to keep the old lockfile version. But I'm not sure lockfile version 1 is supported by any recent versions of npm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly for ciaranj/node-oauth#363, which fixes jaredhanson/passport-oauth2#163. I haven't been able to reproduce that issue with passport-oauth1, but in theory it may be possible.
I'm not aware of any breaking changes in
oauth.See https://github.com/ciaranj/node-oauth/commits