Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data attributes aren't filterable #73

Closed
billerickson opened this issue Feb 12, 2019 · 0 comments
Closed

Data attributes aren't filterable #73

billerickson opened this issue Feb 12, 2019 · 0 comments

Comments

@billerickson
Copy link
Collaborator

We have the shared_counts_link_data filter, but it only used to determine if the $attr array is empty. We then loop through the unfiltered $attr array, defeating the purpose of the filter (see here).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billerickson