We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The shared link can have an invalid href attribute because the url is escaped using esc_attr instead of esc_url
In wp-content\plugins\shared-counts\includes\class-shared-counts-front.php on line 685 replace esc_attr with esc_url
$elements['wrap_open'] = sprintf( '<a href="%s"%s%s%s class="%s"%s>', esc_attr( $link['link'] ), $attr_title, $target, $rel, $css_classes, $data );
$elements['wrap_open'] = sprintf( '<a href="%s"%s%s%s class="%s"%s>', esc_url( $link['link'] ), $attr_title, $target, $rel, $css_classes, $data );
The text was updated successfully, but these errors were encountered:
4a8d0fb
@matsonc I think I figured out why we were using esc_attr() . With this update, the print button no longer works.
esc_attr()
See #133
Sorry, something went wrong.
No branches or pull requests
The shared link can have an invalid href attribute because the url is escaped using esc_attr instead of esc_url
Plugin version 1.4.1
Possible Solution
In wp-content\plugins\shared-counts\includes\class-shared-counts-front.php on line 685
replace esc_attr with esc_url
The text was updated successfully, but these errors were encountered: