Pass mypy and link issues #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
Pass-mypy-and-link-issues
branch
from
789ac31
to
e361d2d
Compare
jaraco
reviewed
Aug 29, 2024
Comment on lines
+8
to
+11
| if sys.version_info >= (3, 9): | ||
| from importlib.resources import files | ||
| else: # pragma: nocover | ||
| from importlib_resources import files |
There was a problem hiding this comment.
Historically, I've been resistant to using this logic, because it feels like using a secondary signal. And typically, I'm averse to changing logic to accommodate types. In this case, I'm happy to follow the popular convention. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: jaraco/skeleton#143
Upstream issues: