Thanks for the contrib. Can you add a test that would fail without these fixes? It may be as simple as adding the known bad cases to inflections.txt.

@jaraco since this fix is for a case where the word is already in singular, just adding it to the inflections.txt cover it, right?

@jaraco since this fix is for a case where the word is already in singular, just adding it to the inflections.txt cover it, right?

Honestly, I don't know. Probably?

This one is so close. Would someone be willing to track down a test that characterizes the failure and fails on main but passes here?

I'd love to. I just forgot to check if that was enough to create the test and run it. But I am going to be afk untill 22nd this month. If no one does it first, I will do it as soon as I come back.

Friendly nudge.

Can you help me setup a dev environment for this package? This way I could also write the tests and check if it is working correctly.

The easiest way to get set up with a dev environment is to get tox. I personally use pipx to install tox, but there are many other ways (including system package managers). Once you have tox and a clone/fork of the repo, simply run tox in the inflect project directory. That will run all of the tests. Presumably, they should pass if you haven't changed anything. If that's not the case, you'll probably want to investigate why the tests aren't passing to ensure they're passing (first check to see if there are similar failures in CI). After you've run the tests, you'll be left with a .tox/py directory, which is a virtualenv with inflect editable-installed, meaning you can run .tox/py/bin/python (or .tox/py/Scripts/python on Windows) and have an environment that can import inflect and get the project as you have checked-out and edited.

After you've written a test, just run tox again and see if it passes or fails. To make things faster, you can run tox -- -k <my test name>, which passes a keyword to pytest saying "only run tests containing ". Any parameters after -- get passed to pytest. You can also pass --pdb to pytest, which will give you a Pdb prompt any time a test fails, useful for inspecting the state of affairs at the point the test fails.

I hope that helps. Let me know if you have any trouble.

I'm going to close this for now, but feel free to revive it when you have interest/time.