Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting inserts a space above header comments that breaks pico-8 cart label #51

Closed
schoblaska opened this issue Dec 23, 2023 · 5 comments · Fixed by #65
Closed

Formatting inserts a space above header comments that breaks pico-8 cart label #51

schoblaska opened this issue Dec 23, 2023 · 5 comments · Fixed by #65
Labels
bug Something isn't working

Comments

@schoblaska
Copy link

When the top of my file looks like this:

pico-8 cartridge // http://www.pico-8.com
version 41
__lua__
-- sokotiles
-- by schoblaska

The cart label gets generated like this:

image

But if I have pico8-ls format the file, it inserts an empty line like this:

pico-8 cartridge // http://www.pico-8.com
version 41
__lua__

-- sokotiles
-- by schoblaska

and now the cart label only includes the first comment:

image
@japhib
Copy link
Owner

japhib commented Dec 23, 2023

Does the formatter insert the space at the top of the file?

@schoblaska
Copy link
Author

I believe so, yes. In my editor, the empty line is only inserted when the pic8-ls extension is enabled.

@schoblaska schoblaska changed the title Inserting a space above header comments breaks pico-8 cart label Formatting inserts a space above header comments that breaks pico-8 cart label Dec 24, 2023
@japhib japhib added the bug Something isn't working label May 16, 2024
@akd-io
Copy link
Contributor

akd-io commented Oct 26, 2024

Faced the same issue. Simple workaround is just removing it and running > File: Save without Formatting before exporting the .p8.png. But would be nice with a patch.

@akd-io
Copy link
Contributor

akd-io commented Oct 26, 2024

Added #65 to try to resolve the issue

@japhib
Copy link
Owner

japhib commented Oct 27, 2024

Released with 0.5.6 just now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants