Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): node_modules of the main plugin unexpectedly copied to the dist-dynamic folder. #1482

Merged

Conversation

davidfestal
Copy link
Member

In some corner cases, the node_modules folder of the main plugin was unexpectedly copied to the dist-dynamic folder. This leads to an erroneous situation where shared packages are added in the dynamic plugin private dependencies.

…he `dist-dynamic` folder.

Signed-off-by: David Festal <[email protected]>
@davidfestal davidfestal requested a review from a team as a code owner April 9, 2024 14:02
@openshift-ci openshift-ci bot requested review from debsmita1 and schultzp2020 April 9, 2024 14:02
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@davidfestal davidfestal changed the title fix(cli) : node_modules of the main plugin unexpectedly copied to the dist-dynamic folder. fix(cli): node_modules of the main plugin unexpectedly copied to the dist-dynamic folder. Apr 9, 2024
Copy link

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gashcrumb
Once this PR has been reviewed and has the lgtm label, please ask for approval from davidfestal. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt merged commit deaa19d into janus-idp:main Apr 9, 2024
9 of 11 checks passed
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.7.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.4.12](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.5.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.2.35](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.1.6](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.2.16](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.2.35](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.8.11](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.16.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.10.5](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.3.11](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.2.12](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.3.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.4.35](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.1.18](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.4.5](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [3.7.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [3.5.12](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.3.34](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.8.9](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.6.6](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.5.17](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.3.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.17.4](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.3.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.3.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.3.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [3.5.18](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.18.14](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.3.12](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-09)

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
janus-idp bot pushed a commit that referenced this pull request Apr 15, 2024
## [1.1.0](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-15)

### Features

* **bulk-import:** allow adding repositories ([#1357](#1357)) ([366a06d](366a06d))
* checkPluginVersion.sh bump plugins for 1.2.0 release ([#1511](#1511)) ([73c6588](73c6588))
* **feedback:** add capture events in feedback plugin ([#1472](#1472)) ([36a12e3](36a12e3))
* **orchestrator:** make workflow last run status as link to the workflow last run details page ([#1488](#1488)) ([fc2f94e](fc2f94e))

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
* **cli:** fix entrypoint validation when running with `npx` ([#1473](#1473)) ([79db649](79db649))
* **cli:** fix the `embed-as-dependencies` option on the `export-dynamic-plugin` CLI... ([#1478](#1478)) ([edd019e](edd019e))
* **feedback-docs:** move out collapsed screenshots ([#1496](#1496)) ([562364d](562364d)), closes [#discussion_r1560988756](https://github.com/janus-idp/backstage-plugins/issues/discussion_r1560988756)

### Documentation

* **orchestrator:** add a quickstart for users ([#1499](#1499)) ([28fe8da](28fe8da))
janus-idp bot pushed a commit that referenced this pull request Apr 15, 2024
## [1.2.0](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-15)

### Features

* **bulk-import:** allow adding repositories ([#1357](#1357)) ([366a06d](366a06d))
* checkPluginVersion.sh bump plugins for 1.2.0 release ([#1511](#1511)) ([73c6588](73c6588))
* **feedback:** add capture events in feedback plugin ([#1472](#1472)) ([36a12e3](36a12e3))
* **orchestrator:** make workflow last run status as link to the workflow last run details page ([#1488](#1488)) ([fc2f94e](fc2f94e))

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
* **cli:** fix entrypoint validation when running with `npx` ([#1473](#1473)) ([79db649](79db649))
* **cli:** fix the `embed-as-dependencies` option on the `export-dynamic-plugin` CLI... ([#1478](#1478)) ([edd019e](edd019e))
* **feedback-docs:** move out collapsed screenshots ([#1496](#1496)) ([562364d](562364d)), closes [#discussion_r1560988756](https://github.com/janus-idp/backstage-plugins/issues/discussion_r1560988756)

### Documentation

* **orchestrator:** add a quickstart for users ([#1499](#1499)) ([28fe8da](28fe8da))
janus-idp bot pushed a commit that referenced this pull request Apr 15, 2024
## [2.3.0](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-15)

### Features

* **bulk-import:** allow adding repositories ([#1357](#1357)) ([366a06d](366a06d))
* checkPluginVersion.sh bump plugins for 1.2.0 release ([#1511](#1511)) ([73c6588](73c6588))
* **feedback:** add capture events in feedback plugin ([#1472](#1472)) ([36a12e3](36a12e3))
* **orchestrator:** make workflow last run status as link to the workflow last run details page ([#1488](#1488)) ([fc2f94e](fc2f94e))

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
* **cli:** fix entrypoint validation when running with `npx` ([#1473](#1473)) ([79db649](79db649))
* **cli:** fix the `embed-as-dependencies` option on the `export-dynamic-plugin` CLI... ([#1478](#1478)) ([edd019e](edd019e))
* **feedback-docs:** move out collapsed screenshots ([#1496](#1496)) ([562364d](562364d)), closes [#discussion_r1560988756](https://github.com/janus-idp/backstage-plugins/issues/discussion_r1560988756)

### Documentation

* **orchestrator:** add a quickstart for users ([#1499](#1499)) ([28fe8da](28fe8da))
janus-idp bot pushed a commit that referenced this pull request Apr 15, 2024
## [2.6.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-15)

### Features

* **bulk-import:** allow adding repositories ([#1357](#1357)) ([366a06d](366a06d))
* checkPluginVersion.sh bump plugins for 1.2.0 release ([#1511](#1511)) ([73c6588](73c6588))
* **orchestrator:** make workflow last run status as link to the workflow last run details page ([#1488](#1488)) ([fc2f94e](fc2f94e))

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
* **feedback-docs:** move out collapsed screenshots ([#1496](#1496)) ([562364d](562364d)), closes [#discussion_r1560988756](https://github.com/janus-idp/backstage-plugins/issues/discussion_r1560988756)

### Documentation

* **orchestrator:** add a quickstart for users ([#1499](#1499)) ([28fe8da](28fe8da))
janus-idp bot pushed a commit that referenced this pull request Apr 15, 2024
## [1.1.0](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-15)

### Features

* **bulk-import:** allow adding repositories ([#1357](#1357)) ([366a06d](366a06d))
* checkPluginVersion.sh bump plugins for 1.2.0 release ([#1511](#1511)) ([73c6588](73c6588))
* **orchestrator:** make workflow last run status as link to the workflow last run details page ([#1488](#1488)) ([fc2f94e](fc2f94e))

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
* **feedback-docs:** move out collapsed screenshots ([#1496](#1496)) ([562364d](562364d)), closes [#discussion_r1560988756](https://github.com/janus-idp/backstage-plugins/issues/discussion_r1560988756)

### Documentation

* **orchestrator:** add a quickstart for users ([#1499](#1499)) ([28fe8da](28fe8da))
janus-idp bot pushed a commit that referenced this pull request Apr 15, 2024
## [2.6.0](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-15)

### Features

* **bulk-import:** allow adding repositories ([#1357](#1357)) ([366a06d](366a06d))
* checkPluginVersion.sh bump plugins for 1.2.0 release ([#1511](#1511)) ([73c6588](73c6588))
* **orchestrator:** make workflow last run status as link to the workflow last run details page ([#1488](#1488)) ([fc2f94e](fc2f94e))

### Bug Fixes

* **cli:** `node_modules` of the main plugin unexpectedly copied to the `dist-dynamic` folder. ([#1482](#1482)) ([deaa19d](deaa19d))
* **feedback-docs:** move out collapsed screenshots ([#1496](#1496)) ([562364d](562364d)), closes [#discussion_r1560988756](https://github.com/janus-idp/backstage-plugins/issues/discussion_r1560988756)

### Documentation

* **orchestrator:** add a quickstart for users ([#1499](#1499)) ([28fe8da](28fe8da))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants