refactor: experimental `embed-as-dependencies` option for the backend #1418

davidfestal · 2024-03-27T14:04:53Z

This PR :

adds an experimental embed-as-dependencies option in the export-dynamic-plugin command for the backend plugins that provides an alternate way of exporting backend plugins as dynamic. In some time it should become the default way. To summarize, it includes embedded packages as private dependencies (ending in the plugin private node_modules) instead of embedding them in the generated code. This is much more robust, enable a better validation of the plugin.
adds a --dynamic-plugins-root option, which can used when using the --dev argument to add the dynamic plugin folder into the dynmaic plugins root of a local backstage-showcase instance. This now works the same for frontend and backend plugins.

kadel · 2024-03-27T15:04:34Z

@davidfestal this should bump minor version of the cli package

packages/cli/src/commands/export-dynamic-plugin/dev.ts

kadel · 2024-03-27T15:54:09Z

I've tried to test new --embed-as-dependencies with a couple of packages.

▶ backstage-plugins/plugins/aap-backend 

▶ npx janus-cli package export-dynamic-plugin --embed-as-dependencies --dev  --dynamic-plugins-root ~/Code/backstage-showcase/dynamic-plugins-root
Building main package
  executing     yarn build ✖

Error: No declaration files found at ../../dist-types/plugins/aap-backend/src/index.d.ts, be sure to run yarn tsc to generate .d.ts files before packaging

error Command failed with exit code 1.
yarn run v1.22.22
$ backstage-cli package build
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Error: Failed to execute command 'yarn build', Error: Command failed: yarn build

Error: No declaration files found at ../../dist-types/plugins/aap-backend/src/index.d.ts, be sure to run yarn tsc to generate .d.ts files before packaging

error Command failed with exit code

after running yarn tsc it still fails

▶ npx janus-cli package export-dynamic-plugin --embed-as-dependencies --dev  --dynamic-plugins-root ~/Code/backstage-showcase/dynamic-plugins-root
Building main package
  executing     yarn build ✔
Packing main package
  moving @backstage/backend-common to peerDependencies
  moving @backstage/backend-plugin-api to peerDependencies
  moving @backstage/backend-tasks to peerDependencies
  moving @backstage/catalog-model to peerDependencies
  moving @backstage/config to peerDependencies
  moving @backstage/plugin-catalog-node to peerDependencies
  moving @backstage/backend-dynamic-feature-service to peerDependencies
Installing private dependencies of the main package
  executing     yarn install --production --frozen-lockfile ✔

Error: Backend plugin is not valid for dynamic loading: it should either export a BackendFeature or BackendFeatureFactory as default export, or export a const dynamicPluginInstaller: BackendDynamicPluginInstaller field as dynamic loading entrypoint

When using the old embedding method, everything works fine.

I'm still trying to understand all that is going on here. Is it possible that I'm using it wrong?

davidfestal · 2024-03-27T16:33:11Z

after running yarn tsc it still fails

Oh, good catch indeed. That's because I added a test to verify that the plugin provides to expected entrypoints.
But I didn't test on plugins which provide new backend system entrypoint point in the alpha entrypoint.
And that's the case of this plugin.

I'll fix this.

davidfestal · 2024-03-27T18:13:57Z

after running yarn tsc it still fails

Oh, good catch indeed. That's because I added a test to verify that the plugin provides to expected entrypoints. But I didn't test on plugins which provide new backend system entrypoint point in the alpha entrypoint. And that's the case of this plugin.

I'll fix this.

Fixed.

davidfestal · 2024-03-27T18:24:06Z

@davidfestal this should bump minor version of the cli package

In fact, I'd like to avoid it to finally indirectly bump the version of all plugins which have a dev dependency on the janus-idp/cli package.

Do you have any idea how it will behave ?

kadel · 2024-03-28T13:02:30Z

In fact, I'd like to avoid it to finally indirectly bump the version of all plugins which have a dev dependency on the janus-idp/cli package.

Do you have any idea how it will behave ?

Oh. I see. Let me test test that. I would assume that if you bump the version manually (not via semantic-release-bot) it should not update it other packages. But let me verify that first

Signed-off-by: David Festal <[email protected]>

sonarqubecloud · 2024-04-02T09:04:26Z

Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.0% Duplication on New Code

See analysis details on SonarCloud

kadel · 2024-04-02T11:18:31Z

/lgtm
/approce

kadel · 2024-04-02T11:18:35Z

/approve

openshift-ci · 2024-04-02T11:18:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

## [1.7.7](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.4.9](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.5.7](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [3.5.9](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.3.29](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.8.5](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.6.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.5.12](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.3.7](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.15.7](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.3.7](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [3.5.14](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.18.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.3.9](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-02) ### Bug Fixes * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.6.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-04) ### Features * **kiali:** istio config list and details ([#1326](#1326)) ([f8fc349](f8fc349)) * **kiali:** update dark theme ([#1434](#1434)) ([e0d84e1](e0d84e1)) * **rbac:** add conditional access button and sidebar ([#1359](#1359)) ([448267d](448267d)) ### Bug Fixes * **feedback-backend:** fix the feedback url for mail and jira ([#1435](#1435)) ([f3564c1](f3564c1)) * **orchestrator:** add lastRunId to overview endpoints ([#1449](#1449)) ([cce56f7](cce56f7)) * **orchestrator:** only inputs inherited from the assessment workflow should be disabled ([#1436](#1436)) ([32d9bdf](32d9bdf)) * **orchestrator:** update devmode container tag ([#1439](#1439)) ([d59ad04](d59ad04)) * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) * **rbac:** rework condition policies to bound them to RBAC roles ([#1330](#1330)) ([55c00b2](55c00b2)) ### Documentation * **orchestrator:** add OpenAPI doc ([#1441](#1441)) ([f6275e2](f6275e2)) * **rbac:** update to the rbac documentation ([#1433](#1433)) ([5d96db3](5d96db3)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [2.5.1](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-04) ### Features * **kiali:** istio config list and details ([#1326](#1326)) ([f8fc349](f8fc349)) * **kiali:** update dark theme ([#1434](#1434)) ([e0d84e1](e0d84e1)) * **rbac:** add conditional access button and sidebar ([#1359](#1359)) ([448267d](448267d)) ### Bug Fixes * **feedback-backend:** fix the feedback url for mail and jira ([#1435](#1435)) ([f3564c1](f3564c1)) * **orchestrator:** add lastRunId to overview endpoints ([#1449](#1449)) ([cce56f7](cce56f7)) * **orchestrator:** only inputs inherited from the assessment workflow should be disabled ([#1436](#1436)) ([32d9bdf](32d9bdf)) * **orchestrator:** update devmode container tag ([#1439](#1439)) ([d59ad04](d59ad04)) * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) * **rbac:** rework condition policies to bound them to RBAC roles ([#1330](#1330)) ([55c00b2](55c00b2)) ### Documentation * **orchestrator:** add OpenAPI doc ([#1441](#1441)) ([f6275e2](f6275e2)) * **rbac:** update to the rbac documentation ([#1433](#1433)) ([5d96db3](5d96db3)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.0.4](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-05) ### Features * **kiali:** istio config list and details ([#1326](#1326)) ([f8fc349](f8fc349)) * **kiali:** update dark theme ([#1434](#1434)) ([e0d84e1](e0d84e1)) * **rbac:** add conditional access button and sidebar ([#1359](#1359)) ([448267d](448267d)) * **rbac:** save role modification information to the metadata ([#1280](#1280)) ([0454509](0454509)) ### Bug Fixes * **feedback-backend:** fix the feedback url for mail and jira ([#1435](#1435)) ([f3564c1](f3564c1)) * **orchestrator:** add lastRunId to overview endpoints ([#1449](#1449)) ([cce56f7](cce56f7)) * **orchestrator:** only inputs inherited from the assessment workflow should be disabled ([#1436](#1436)) ([32d9bdf](32d9bdf)) * **orchestrator:** update devmode container tag ([#1439](#1439)) ([d59ad04](d59ad04)) * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) * **rbac:** rework condition policies to bound them to RBAC roles ([#1330](#1330)) ([55c00b2](55c00b2)) ### Documentation * **orchestrator:** add OpenAPI doc ([#1441](#1441)) ([f6275e2](f6275e2)) * **rbac:** update to the rbac documentation ([#1433](#1433)) ([5d96db3](5d96db3)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.0.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-05) ### Features * **kiali:** istio config list and details ([#1326](#1326)) ([f8fc349](f8fc349)) * **kiali:** update dark theme ([#1434](#1434)) ([e0d84e1](e0d84e1)) * **rbac:** add conditional access button and sidebar ([#1359](#1359)) ([448267d](448267d)) * **rbac:** save role modification information to the metadata ([#1280](#1280)) ([0454509](0454509)) ### Bug Fixes * **feedback-backend:** fix the feedback url for mail and jira ([#1435](#1435)) ([f3564c1](f3564c1)) * **orchestrator:** add lastRunId to overview endpoints ([#1449](#1449)) ([cce56f7](cce56f7)) * **orchestrator:** only inputs inherited from the assessment workflow should be disabled ([#1436](#1436)) ([32d9bdf](32d9bdf)) * **orchestrator:** update devmode container tag ([#1439](#1439)) ([d59ad04](d59ad04)) * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) * **rbac:** rework condition policies to bound them to RBAC roles ([#1330](#1330)) ([55c00b2](55c00b2)) ### Documentation * **orchestrator:** add OpenAPI doc ([#1441](#1441)) ([f6275e2](f6275e2)) * **rbac:** update to the rbac documentation ([#1433](#1433)) ([5d96db3](5d96db3)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [2.2.4](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-05) ### Features * **kiali:** istio config list and details ([#1326](#1326)) ([f8fc349](f8fc349)) * **kiali:** update dark theme ([#1434](#1434)) ([e0d84e1](e0d84e1)) * **rbac:** add conditional access button and sidebar ([#1359](#1359)) ([448267d](448267d)) * **rbac:** save role modification information to the metadata ([#1280](#1280)) ([0454509](0454509)) ### Bug Fixes * **feedback-backend:** fix the feedback url for mail and jira ([#1435](#1435)) ([f3564c1](f3564c1)) * **orchestrator:** add lastRunId to overview endpoints ([#1449](#1449)) ([cce56f7](cce56f7)) * **orchestrator:** only inputs inherited from the assessment workflow should be disabled ([#1436](#1436)) ([32d9bdf](32d9bdf)) * **orchestrator:** update devmode container tag ([#1439](#1439)) ([d59ad04](d59ad04)) * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) * **rbac:** rework condition policies to bound them to RBAC roles ([#1330](#1330)) ([55c00b2](55c00b2)) ### Documentation * **orchestrator:** add OpenAPI doc ([#1441](#1441)) ([f6275e2](f6275e2)) * **rbac:** update to the rbac documentation ([#1433](#1433)) ([5d96db3](5d96db3)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.0.5](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-08) ### Features * **kiali:** istio config list and details ([#1326](#1326)) ([f8fc349](f8fc349)) * **kiali:** update dark theme ([#1434](#1434)) ([e0d84e1](e0d84e1)) * **rbac:** add conditional access button and sidebar ([#1359](#1359)) ([448267d](448267d)) * **rbac:** save role modification information to the metadata ([#1280](#1280)) ([0454509](0454509)) ### Bug Fixes * **feedback-backend:** fix the feedback url for mail and jira ([#1435](#1435)) ([f3564c1](f3564c1)) * **orchestrator:** add lastRunId to overview endpoints ([#1449](#1449)) ([cce56f7](cce56f7)) * **orchestrator:** only inputs inherited from the assessment workflow should be disabled ([#1436](#1436)) ([32d9bdf](32d9bdf)) * **orchestrator:** update devmode container tag ([#1439](#1439)) ([d59ad04](d59ad04)) * **rbac:** align styles with UXD ([#1416](#1416)) ([1df3592](1df3592)) * **rbac:** rework condition policies to bound them to RBAC roles ([#1330](#1330)) ([55c00b2](55c00b2)) ### Documentation * **orchestrator:** add OpenAPI doc ([#1441](#1441)) ([f6275e2](f6275e2)) * **rbac:** update to the rbac documentation ([#1433](#1433)) ([5d96db3](5d96db3)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([#1418](#1418)) ([b451380](b451380))

## [1.6.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-04) ### Features * **kiali:** istio config list and details ([janus-idp#1326](janus-idp#1326)) ([f8fc349](janus-idp@f8fc349)) * **kiali:** update dark theme ([janus-idp#1434](janus-idp#1434)) ([e0d84e1](janus-idp@e0d84e1)) * **rbac:** add conditional access button and sidebar ([janus-idp#1359](janus-idp#1359)) ([448267d](janus-idp@448267d)) ### Bug Fixes * **feedback-backend:** fix the feedback url for mail and jira ([janus-idp#1435](janus-idp#1435)) ([f3564c1](janus-idp@f3564c1)) * **orchestrator:** add lastRunId to overview endpoints ([janus-idp#1449](janus-idp#1449)) ([cce56f7](janus-idp@cce56f7)) * **orchestrator:** only inputs inherited from the assessment workflow should be disabled ([janus-idp#1436](janus-idp#1436)) ([32d9bdf](janus-idp@32d9bdf)) * **orchestrator:** update devmode container tag ([janus-idp#1439](janus-idp#1439)) ([d59ad04](janus-idp@d59ad04)) * **rbac:** align styles with UXD ([janus-idp#1416](janus-idp#1416)) ([1df3592](janus-idp@1df3592)) * **rbac:** rework condition policies to bound them to RBAC roles ([janus-idp#1330](janus-idp#1330)) ([55c00b2](janus-idp@55c00b2)) ### Documentation * **orchestrator:** add OpenAPI doc ([janus-idp#1441](janus-idp#1441)) ([f6275e2](janus-idp@f6275e2)) * **rbac:** update to the rbac documentation ([janus-idp#1433](janus-idp#1433)) ([5d96db3](janus-idp@5d96db3)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([janus-idp#1418](janus-idp#1418)) ([b451380](janus-idp@b451380))

## [2.5.1](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-04) ### Features * **kiali:** istio config list and details ([janus-idp#1326](janus-idp#1326)) ([f8fc349](janus-idp@f8fc349)) * **kiali:** update dark theme ([janus-idp#1434](janus-idp#1434)) ([e0d84e1](janus-idp@e0d84e1)) * **rbac:** add conditional access button and sidebar ([janus-idp#1359](janus-idp#1359)) ([448267d](janus-idp@448267d)) ### Bug Fixes * **feedback-backend:** fix the feedback url for mail and jira ([janus-idp#1435](janus-idp#1435)) ([f3564c1](janus-idp@f3564c1)) * **orchestrator:** add lastRunId to overview endpoints ([janus-idp#1449](janus-idp#1449)) ([cce56f7](janus-idp@cce56f7)) * **orchestrator:** only inputs inherited from the assessment workflow should be disabled ([janus-idp#1436](janus-idp#1436)) ([32d9bdf](janus-idp@32d9bdf)) * **orchestrator:** update devmode container tag ([janus-idp#1439](janus-idp#1439)) ([d59ad04](janus-idp@d59ad04)) * **rbac:** align styles with UXD ([janus-idp#1416](janus-idp#1416)) ([1df3592](janus-idp@1df3592)) * **rbac:** rework condition policies to bound them to RBAC roles ([janus-idp#1330](janus-idp#1330)) ([55c00b2](janus-idp@55c00b2)) ### Documentation * **orchestrator:** add OpenAPI doc ([janus-idp#1441](janus-idp#1441)) ([f6275e2](janus-idp@f6275e2)) * **rbac:** update to the rbac documentation ([janus-idp#1433](janus-idp#1433)) ([5d96db3](janus-idp@5d96db3)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([janus-idp#1418](janus-idp#1418)) ([b451380](janus-idp@b451380))

## [1.0.4](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-05) ### Features * **kiali:** istio config list and details ([janus-idp#1326](janus-idp#1326)) ([f8fc349](janus-idp@f8fc349)) * **kiali:** update dark theme ([janus-idp#1434](janus-idp#1434)) ([e0d84e1](janus-idp@e0d84e1)) * **rbac:** add conditional access button and sidebar ([janus-idp#1359](janus-idp#1359)) ([448267d](janus-idp@448267d)) * **rbac:** save role modification information to the metadata ([janus-idp#1280](janus-idp#1280)) ([0454509](janus-idp@0454509)) ### Bug Fixes * **feedback-backend:** fix the feedback url for mail and jira ([janus-idp#1435](janus-idp#1435)) ([f3564c1](janus-idp@f3564c1)) * **orchestrator:** add lastRunId to overview endpoints ([janus-idp#1449](janus-idp#1449)) ([cce56f7](janus-idp@cce56f7)) * **orchestrator:** only inputs inherited from the assessment workflow should be disabled ([janus-idp#1436](janus-idp#1436)) ([32d9bdf](janus-idp@32d9bdf)) * **orchestrator:** update devmode container tag ([janus-idp#1439](janus-idp#1439)) ([d59ad04](janus-idp@d59ad04)) * **rbac:** align styles with UXD ([janus-idp#1416](janus-idp#1416)) ([1df3592](janus-idp@1df3592)) * **rbac:** rework condition policies to bound them to RBAC roles ([janus-idp#1330](janus-idp#1330)) ([55c00b2](janus-idp@55c00b2)) ### Documentation * **orchestrator:** add OpenAPI doc ([janus-idp#1441](janus-idp#1441)) ([f6275e2](janus-idp@f6275e2)) * **rbac:** update to the rbac documentation ([janus-idp#1433](janus-idp#1433)) ([5d96db3](janus-idp@5d96db3)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([janus-idp#1418](janus-idp#1418)) ([b451380](janus-idp@b451380))

## [1.0.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-05) ### Features * **kiali:** istio config list and details ([janus-idp#1326](janus-idp#1326)) ([f8fc349](janus-idp@f8fc349)) * **kiali:** update dark theme ([janus-idp#1434](janus-idp#1434)) ([e0d84e1](janus-idp@e0d84e1)) * **rbac:** add conditional access button and sidebar ([janus-idp#1359](janus-idp#1359)) ([448267d](janus-idp@448267d)) * **rbac:** save role modification information to the metadata ([janus-idp#1280](janus-idp#1280)) ([0454509](janus-idp@0454509)) ### Bug Fixes * **feedback-backend:** fix the feedback url for mail and jira ([janus-idp#1435](janus-idp#1435)) ([f3564c1](janus-idp@f3564c1)) * **orchestrator:** add lastRunId to overview endpoints ([janus-idp#1449](janus-idp#1449)) ([cce56f7](janus-idp@cce56f7)) * **orchestrator:** only inputs inherited from the assessment workflow should be disabled ([janus-idp#1436](janus-idp#1436)) ([32d9bdf](janus-idp@32d9bdf)) * **orchestrator:** update devmode container tag ([janus-idp#1439](janus-idp#1439)) ([d59ad04](janus-idp@d59ad04)) * **rbac:** align styles with UXD ([janus-idp#1416](janus-idp#1416)) ([1df3592](janus-idp@1df3592)) * **rbac:** rework condition policies to bound them to RBAC roles ([janus-idp#1330](janus-idp#1330)) ([55c00b2](janus-idp@55c00b2)) ### Documentation * **orchestrator:** add OpenAPI doc ([janus-idp#1441](janus-idp#1441)) ([f6275e2](janus-idp@f6275e2)) * **rbac:** update to the rbac documentation ([janus-idp#1433](janus-idp#1433)) ([5d96db3](janus-idp@5d96db3)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([janus-idp#1418](janus-idp#1418)) ([b451380](janus-idp@b451380))

## [2.2.4](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-05) ### Features * **kiali:** istio config list and details ([janus-idp#1326](janus-idp#1326)) ([f8fc349](janus-idp@f8fc349)) * **kiali:** update dark theme ([janus-idp#1434](janus-idp#1434)) ([e0d84e1](janus-idp@e0d84e1)) * **rbac:** add conditional access button and sidebar ([janus-idp#1359](janus-idp#1359)) ([448267d](janus-idp@448267d)) * **rbac:** save role modification information to the metadata ([janus-idp#1280](janus-idp#1280)) ([0454509](janus-idp@0454509)) ### Bug Fixes * **feedback-backend:** fix the feedback url for mail and jira ([janus-idp#1435](janus-idp#1435)) ([f3564c1](janus-idp@f3564c1)) * **orchestrator:** add lastRunId to overview endpoints ([janus-idp#1449](janus-idp#1449)) ([cce56f7](janus-idp@cce56f7)) * **orchestrator:** only inputs inherited from the assessment workflow should be disabled ([janus-idp#1436](janus-idp#1436)) ([32d9bdf](janus-idp@32d9bdf)) * **orchestrator:** update devmode container tag ([janus-idp#1439](janus-idp#1439)) ([d59ad04](janus-idp@d59ad04)) * **rbac:** align styles with UXD ([janus-idp#1416](janus-idp#1416)) ([1df3592](janus-idp@1df3592)) * **rbac:** rework condition policies to bound them to RBAC roles ([janus-idp#1330](janus-idp#1330)) ([55c00b2](janus-idp@55c00b2)) ### Documentation * **orchestrator:** add OpenAPI doc ([janus-idp#1441](janus-idp#1441)) ([f6275e2](janus-idp@f6275e2)) * **rbac:** update to the rbac documentation ([janus-idp#1433](janus-idp#1433)) ([5d96db3](janus-idp@5d96db3)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([janus-idp#1418](janus-idp#1418)) ([b451380](janus-idp@b451380))

## [1.0.5](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-04-08) ### Features * **kiali:** istio config list and details ([janus-idp#1326](janus-idp#1326)) ([f8fc349](janus-idp@f8fc349)) * **kiali:** update dark theme ([janus-idp#1434](janus-idp#1434)) ([e0d84e1](janus-idp@e0d84e1)) * **rbac:** add conditional access button and sidebar ([janus-idp#1359](janus-idp#1359)) ([448267d](janus-idp@448267d)) * **rbac:** save role modification information to the metadata ([janus-idp#1280](janus-idp#1280)) ([0454509](janus-idp@0454509)) ### Bug Fixes * **feedback-backend:** fix the feedback url for mail and jira ([janus-idp#1435](janus-idp#1435)) ([f3564c1](janus-idp@f3564c1)) * **orchestrator:** add lastRunId to overview endpoints ([janus-idp#1449](janus-idp#1449)) ([cce56f7](janus-idp@cce56f7)) * **orchestrator:** only inputs inherited from the assessment workflow should be disabled ([janus-idp#1436](janus-idp#1436)) ([32d9bdf](janus-idp@32d9bdf)) * **orchestrator:** update devmode container tag ([janus-idp#1439](janus-idp#1439)) ([d59ad04](janus-idp@d59ad04)) * **rbac:** align styles with UXD ([janus-idp#1416](janus-idp#1416)) ([1df3592](janus-idp@1df3592)) * **rbac:** rework condition policies to bound them to RBAC roles ([janus-idp#1330](janus-idp#1330)) ([55c00b2](janus-idp@55c00b2)) ### Documentation * **orchestrator:** add OpenAPI doc ([janus-idp#1441](janus-idp#1441)) ([f6275e2](janus-idp@f6275e2)) * **rbac:** update to the rbac documentation ([janus-idp#1433](janus-idp#1433)) ([5d96db3](janus-idp@5d96db3)) ### Other changes * experimental `embed-as-dependencies` option for the backend ([janus-idp#1418](janus-idp#1418)) ([b451380](janus-idp@b451380))

davidfestal requested a review from a team as a code owner March 27, 2024 14:04

openshift-ci bot requested review from schultzp2020 and tumido March 27, 2024 14:04

davidfestal requested review from kadel and BethGriggs March 27, 2024 14:05

kadel reviewed Mar 27, 2024

View reviewed changes

packages/cli/src/commands/export-dynamic-plugin/dev.ts Show resolved Hide resolved

davidfestal force-pushed the rework-cli-export-dynamic branch from 5c3a357 to 5293d2d Compare March 27, 2024 18:13

davidfestal changed the title ~~Experimental embed-as-dependencies option for the backend~~ refactor: experimental embed-as-dependencies option for the backend Mar 27, 2024

openshift-merge-robot added the needs-rebase label Mar 28, 2024

Experimental embed-as-dependencies option...

13bfbfa

Signed-off-by: David Festal <[email protected]>

davidfestal force-pushed the rework-cli-export-dynamic branch from 5293d2d to 13bfbfa Compare April 2, 2024 09:03

openshift-merge-robot removed the needs-rebase label Apr 2, 2024

openshift-ci bot assigned kadel Apr 2, 2024

openshift-ci bot added the lgtm label Apr 2, 2024

openshift-ci bot added approved do-not-merge/hold labels Apr 2, 2024

openshift-merge-bot bot merged commit b451380 into janus-idp:main Apr 2, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: experimental `embed-as-dependencies` option for the backend #1418

refactor: experimental `embed-as-dependencies` option for the backend #1418

davidfestal commented Mar 27, 2024

kadel commented Mar 27, 2024

kadel commented Mar 27, 2024

davidfestal commented Mar 27, 2024

davidfestal commented Mar 27, 2024

davidfestal commented Mar 27, 2024

kadel commented Mar 28, 2024

sonarqubecloud bot commented Apr 2, 2024

kadel commented Apr 2, 2024

kadel commented Apr 2, 2024

openshift-ci bot commented Apr 2, 2024

refactor: experimental embed-as-dependencies option for the backend #1418

refactor: experimental embed-as-dependencies option for the backend #1418

Conversation

davidfestal commented Mar 27, 2024

kadel commented Mar 27, 2024

kadel commented Mar 27, 2024

davidfestal commented Mar 27, 2024

davidfestal commented Mar 27, 2024

davidfestal commented Mar 27, 2024

kadel commented Mar 28, 2024

sonarqubecloud bot commented Apr 2, 2024

Quality Gate passed

kadel commented Apr 2, 2024

kadel commented Apr 2, 2024

openshift-ci bot commented Apr 2, 2024

refactor: experimental `embed-as-dependencies` option for the backend #1418

refactor: experimental `embed-as-dependencies` option for the backend #1418