Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBAC - Discover and implement adjustments needed for the plugin to work in the showcase provided "Administration" tab #1165

Closed
gashcrumb opened this issue Feb 2, 2024 · 3 comments · Fixed by #1185
Assignees
Labels
jira kind/enhancement New feature or request

Comments

@gashcrumb
Copy link
Member

What do you want to improve?

Adjust the exported components from the RBAC fronttend plugin

What is the current behavior?

Currently the RBAC frontend plugin exposes one component that contains the entire page. To improve the usage of these views for a dynamic front end it would be good to add some additional exposed components, as currently when trying to mount the available page component:

image

What will the new behavior be?

The existing page component will still be available, and an additional component will be available that contains only the RBAC plugin components excluding the surrounding page and header components.

@gashcrumb gashcrumb added kind/enhancement New feature or request jira labels Feb 2, 2024
@gashcrumb gashcrumb self-assigned this Feb 2, 2024
@gashcrumb
Copy link
Member Author

Need to consider how this page would work:

image

@gashcrumb
Copy link
Member Author

With some tweaks mostly on the application shell side I have several cases now working well, for example:

image

And then clicking "Create":

image

Or looking at a role:

image

Also the delete dialog appears to work okay:

image

Clicking on "Edit" however:

image

This case also happens when clicking "Cancel" after clicking "New" and also when clicking the "RBAC" link on the Overview page. Some of the other edit/pencil icons may behave the same.

@gashcrumb
Copy link
Member Author

With some adjustments to the plugin to replace absolute URLs with relative URLs this is now working quite nicely, if I click on the "Edit" pencil icon for a role now I'm routed to:

image

Clicking "Cancel" in the above brings me back to the table:

image

From this page I can get to the overview:

image

Clicking on the pencil icon in "Users and groups" brings me to:

image

And clicking on the pencil icon in "Permission Policies" brings me to:

image

One last item to address is this link:

image

@gashcrumb gashcrumb changed the title RBAC - Expose an additional UI component to support more fine grained composition RBAC - Discover and implement adjustments needed for the plugin to work in the showcase provided "Administration" tab Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant