Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tekton plugin]: Clicking on view sbom task with external link opens logs modal. #1151

Closed
karthikjeeyar opened this issue Feb 1, 2024 · 0 comments
Assignees

Comments

@karthikjeeyar
Copy link
Contributor

Describe the bug

On clicking on View SBOM action, the users is properly redirected to external-link when the task contains external-link annotation, but the internal sbom logs dialog is also opened at the same time. Logs modal should be opened only when this external-link annotation is not set.

External-sbom-viewer-opens-logs.mov

Expected Behavior

Incase of external SBOM task, the internal logs modal shouldn't be opened.

What are the steps to reproduce this bug?

  1. Create a SBOM task with external link SBOM Task with external link annotation.
  2. Create a pipelinerun with above task and View sbom action will be enabled.
  3. Click on the View SBOM action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant