Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Janus Kiali Plugin declares a config but does not define one. #1100

Open
mikeymop opened this issue Jan 22, 2024 · 1 comment
Open

Janus Kiali Plugin declares a config but does not define one. #1100

mikeymop opened this issue Jan 22, 2024 · 1 comment

Comments

@mikeymop
Copy link

Describe the bug

A clear and concise description of what the bug is. (provide screenshots if applicable)

When using the latest version of @janus-idp/backstage-plugin-kiali (version 1.8.1 at the timeI noticed that thepackage.jsondefines aconfig.d.tshowever the module bundle does not declare aconfig.d.ts`.

This causes a very hard to resolve error where any parsed plugin after kiali will report an error that their config is not defined.

If you look in the plugin's package.json you will find the following:

"configSchema": "config.d.ts",
"files": [
  "dist",
  "dist-scalprum"
]

Looking at the backstage docs, config.d.ts should also be defined in files. Additionally a config.d.ts is not defined in the resulting plugin bundle ./node_modules/@janus-idp/backstage-plugin-kiali/config.d.ts

Expected Behavior

The plugin should either define a configuration schema or remove the declared configuration from it's package.json.

What are the steps to reproduce this bug?

  1. Install @janus-idp/backstage-plugin-kiali
  2. yarn start in the root of your backstage project
  3. Observe the following errors:
File "../../node_modules/@janus-idp/backstage-plugin-kiali/config.d.ts" not found.
  The file is in the program because:
      Root file specified for compilation

Versions of software used and environment

packag.json:

dependencies: {
    "@janus-idp/backstage-plugin-kiali-backend": "^1.8.1"
}
@mikeymop mikeymop added kind/bug Something isn't working status/triage labels Jan 22, 2024
@github-actions github-actions bot added the jira label Jan 22, 2024
@aljesusg
Copy link
Contributor

This is weird.
config.d.ts

Anyway we need to remove that config.d.ts all configuration is set in the backend let me address this one with my actual PR.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants