remove --force from npm install in CI

janosh · Feb 17, 2024 · 63768e8 · 63768e8
1 parent f271393
commit 63768e8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/.github/workflows/gh-pages.yml b/.github/workflows/gh-pages.yml
@@ -10,5 +10,3 @@ on:
 jobs:
   build:
     uses: janosh/workflows/.github/workflows/nodejs-gh-pages.yml@main
-    with:
-      install-cmd: npm install -f
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -19,7 +19,7 @@ repos:
       - id: trailing-whitespace
 
   - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: v3.1.0
+    rev: v4.0.0-alpha.8
     hooks:
       - id: prettier
         args: [--write] # edit files in-place
@@ -37,7 +37,7 @@ repos:
         exclude: changelog\.md
 
   - repo: https://github.com/pre-commit/mirrors-eslint
-    rev: v8.53.0
+    rev: v9.0.0-beta.0
     hooks:
       - id: eslint
         types: [file]

diff --git a/tests/MultiSelect.test.ts b/tests/MultiSelect.test.ts
@@ -46,10 +46,9 @@ test.describe(`input`, async () => {
 
     await page.fill(`#foods input[autocomplete]`, `Pineapple`)
 
-    expect(
-      await page.$$(`div.multiselect.open > ul.options > li`),
-    ).toHaveLength(1)
-    const text = await page.textContent(`div.multiselect.open > ul.options`)
+    const ul_selector = `div.multiselect.open > ul.options`
+    expect(await page.$$(`${ul_selector} > li`)).toHaveLength(1)
+    const text = await page.textContent(ul_selector)
     expect(text?.trim()).toBe(`🍍 Pineapple`)
   })
 })
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,5 +10,3 @@ on: @@
     jobs:
       build:
         uses: janosh/workflows/.github/workflows/nodejs-gh-pages.yml@main
-        with:
-          install-cmd: npm install -f