-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use continues benchmark to track long term performance #150
Comments
AFAIK the benchmark will run on GitHub actions for every build. One question that comes to my mind is if the performance is really comparable when the runtime environment (computational setup, CPU, RAM etc.) of the benchmark cannot be controlled? |
There are two main variables HardwareSometimes the performance could be very different(maybe the CPU load caused), take tzf as example https://ringsaturn.github.io/tzf/ the performance will regression after many benchmark has runned. That’s part we can’t control. Just run many times and wait the trends came to the regression. Project based envSometimes we need to test under multi env, like OS/verison, and that we can set in GA. An internal project uploads different env benchmark data to different folder, such as Go’s version: - name: Continuous Benchmark
uses: benchmark-action/[email protected]
with:
name: Go Benchmark
tool: 'go'
output-file-path: ${{ matrix.go }}_benchmark_result.txt
github-token: ${{ secrets.TOKEN }}
gh-repository: 'github.com/xxxxx/yyyyy'
auto-push: true
alert-threshold: '200%'
comment-on-alert: true
fail-on-alert: false
gh-pages-branch: "benchmark"
benchmark-data-dir-path: "benchmark/${{ matrix.go }}/"
alert-comment-cc-users: '@ringsaturn' The save path need a unique path and then we can see diffent benchmark results:
If we need a page to view, we can add |
Another problem I know is that if PR isn’t opened by owner, secret token couldn’t be accessed like ringsaturn/tz-benchmark#7 |
For future reference: the scripts folder already contains scripts for time benchmarks |
https://github.com/marketplace/actions/continuous-benchmark could save each commit’s benchmark results to a file, and come with a nice HTML page to view trends, I believe it will be useful for performance improvements.
The text was updated successfully, but these errors were encountered: