Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we copy the ODM model structure #14

Open
jannefiluren opened this issue Oct 20, 2017 · 3 comments
Open

Should we copy the ODM model structure #14

jannefiluren opened this issue Oct 20, 2017 · 3 comments

Comments

@jannefiluren
Copy link
Owner

Shouldn´t we copy the model structure from ODM such that we have completly parallell models?

This is quite tedious. Perhaps Bård can make a c# library that we can call?

@kolbjornengeland
Copy link
Collaborator

The similarity could be for only elevation Distributed models. So that we use
1: The same way to define elevation bands. Then it is much easyer to use the same data inputs
2: The same way to use landuse types.
3: the same implementation of model algorithms. For the last two points, the transition from results in Julia to implementation in ODM will be smooth. If not we will need to re-alibrate HBV models and even assimilation algorithms when and if implementing in ODM.

Stein has identical algorithms in C++, so maybe it is a better choice if we should be able to use it both on Lunix and Windows.

@jannefiluren
Copy link
Owner Author

1: The same way to define elevation bands. Then it is much easyer to use the same data inputs

The model can handle any number of elevation bands right now, so using the "standard format" will be easy.

2: The same way to use landuse types.

Yes, that we can do once we have those. Lets see what Bård comes up with.

@ElinLangsholt
Copy link

1: The same way to define elevation bands. Then it is much easyer to use the same data inputs

The 10 (eqially sized) bands in ODM/HBV are defines by the 11 boundaries between them. In Vann it seems that 10 bands would be defined by their mean band altitudes. But I guess that is the only attribute that needs a slight recalculation if we chose equal size for the Vann bands?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants