Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow often just reorder resolvers.txt rather than making real changes #36

Open
berney opened this issue Oct 17, 2023 · 0 comments
Open

Comments

@berney
Copy link

berney commented Oct 17, 2023

The workflow runs off the existing resolvers.txt and commits the results back.
But the order is nondeterministic, so it often just changing the ordering in the file.

Looking at the last 683 commits (1y2m), there's been no real changes, if we sort the file:

for c in $(git log --format="%h" -n 683); do git show "$c":resolvers.txt | sort | md5sum; done | sort | uniq -c
    683 88ed3d61baa70f89764f6477540ccc5c  -

The last real change was 59b240f:

diff <(git show 59b240f:resolvers.txt | sort ) <(cat resolvers.txt | sort)

9d8
< 80.67.169.12

IIUC slowly overtime resolvers are being removed, but I don't think new ones can be added.

IMO it would be better to sort the file in the workflow and then only commit if there is a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant