Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom delimiters in nested partials #739

Merged
merged 1 commit into from
Mar 15, 2020
Merged

Fix custom delimiters in nested partials #739

merged 1 commit into from
Mar 15, 2020

Conversation

aielo
Copy link
Contributor

@aielo aielo commented Feb 25, 2020

Fix to #738.

Changes:

  • Parameter tags added to renderTokens calls from renderPartial
  • Nested partials should support custom delimiters. test added to partial-test.js

phillipj
phillipj approved these changes Mar 15, 2020
View reviewed changes
Copy link
Collaborator

@phillipj phillipj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LooksReallyGreatToMe!

@phillipj phillipj changed the title Fix custom delimiters in nested partials (#738) Fix custom delimiters in nested partials Mar 15, 2020
@phillipj phillipj merged commit f3bd888 into janl:master Mar 15, 2020
@phillipj
Copy link
Collaborator

v4.0.1 published 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipj phillipj phillipj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aielo @phillipj