Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Only show message queue when users enter their second message #939

Closed
imtuyethan opened this issue Dec 11, 2023 · 4 comments
Closed
Assignees
Labels
P2: nice to have Nice to have feature type: bug Something isn't working

Comments

@imtuyethan
Copy link
Contributor

Problem:
Right now, when users enter their first message, Jan shows "Message queue" message right away:

Screen.Recording.2023-12-11.at.3.27.36.PM.mov

Meanwhile, the correct flow is:

If the thread uses the same model as the current active model: Users send message & receive response normally

Screenshot 2023-12-11 at 3 31 13 PM

If the thread uses a different model

  • Once users enter the first message -> send that message + start model:
    Input message
    (Inputing message)

Starting model
(Message sent + starting model)

  • When model is starting, we will not disable the input field, if users continue to input...
    Continue inputing message
  • Once they click send, it cannot be sent and show "message queue" status:
    Message queue

Note that the "message queue" message should disappear after 3 seconds, and if users type send again while model is still starting -> show that message again

Figma flow: https://www.figma.com/file/ytn1nRZ17FUmJHTlhmZB9f/Jan-App?type=design&node-id=549-43054&mode=design&t=59imhnuCTJu4oesf-4

@imtuyethan imtuyethan added P2: nice to have Nice to have feature type: bug Something isn't working labels Dec 11, 2023
@imtuyethan imtuyethan added this to the 0.4.1 milestone Dec 11, 2023
@urmauur
Copy link
Member

urmauur commented Dec 11, 2023

@imtuyethan CMIIW in your video you don't have active model, so that why you got Message queue

@imtuyethan
Copy link
Contributor Author

@imtuyethan CMIIW in your video you don't have active model, so that why you got Message queue

Yes, what i mean is that if i don't have active model, it should start the model without showing message "Message Queue". You can read the flow i typed out.

@louis-menlo
Copy link
Contributor

Sorry @urmauur, let us align on this issue for the appropriate fix. Might #886 is the one should be done before this.

@freelerobot freelerobot moved this to Triaged (Backlog) in Menlo Dec 14, 2023
@freelerobot freelerobot moved this from Triaged (Backlog) to Todo in Menlo Dec 18, 2023
@freelerobot
Copy link
Contributor

KIV'ing this for the future when we do allow model switching in existing threads

@github-project-automation github-project-automation bot moved this from Todo to Done in Menlo Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2: nice to have Nice to have feature type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants