Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roadmap: Jan supports Deepseek Distilled Models for v0.5.14 #4499

Closed
1 task
imtuyethan opened this issue Jan 21, 2025 · 1 comment
Closed
1 task

roadmap: Jan supports Deepseek Distilled Models for v0.5.14 #4499

imtuyethan opened this issue Jan 21, 2025 · 1 comment
Assignees
Labels
category: model support Support new model, or fix broken model P1: important Important feature / fix type: feature request A new feature
Milestone

Comments

@imtuyethan
Copy link
Contributor

imtuyethan commented Jan 21, 2025

Goal

  • Jan supports distilled models
  • Out-of-scope: Deepseek R1 (wait for llama.cpp support)

Problems

  • Problem 1: We are unable to pick up the chat_template from GGUF file due to Cortex's design
    • GGUF uses a Jinja2 template
    • We currently parse Jinja templates into Cortex's format
    • This causes a lot of compatibility issues
  • Problem 2: We do not persist the prompt_template changes in Jan
    • User has to change it every time

Workaround

We will do a quick fix in the short-term, while working to align Cortex in the long-term

  • Solution 1: We quantize the model ourselves with our own prompt_template
    • janhq/deepseek-distill-qwen2
    • main branch can hold the legacy GGUF format (to support current Jan)
    • Include it in Jan's Hub
  • Solution 2: User has to paste in a system prompt template into Jan (which is not 100% correct)
    • bartowski/...

Tasklist

  • Models

Image

@imtuyethan imtuyethan added the type: feature request A new feature label Jan 21, 2025
@github-project-automation github-project-automation bot moved this to Investigating in Menlo Jan 21, 2025
@imtuyethan imtuyethan added this to the v0.5.14 milestone Jan 21, 2025
@imtuyethan imtuyethan moved this from Investigating to In Progress in Menlo Jan 21, 2025
@imtuyethan imtuyethan added the category: model support Support new model, or fix broken model label Jan 21, 2025
@imtuyethan imtuyethan changed the title idea: Jan supports Deepseek model feat: Jan supports Deepseek model Jan 21, 2025
@imtuyethan imtuyethan changed the title feat: Jan supports Deepseek model roadmap: Jan supports Deepseek model Jan 22, 2025
@imtuyethan imtuyethan added the P1: important Important feature / fix label Jan 22, 2025
@imtuyethan imtuyethan changed the title roadmap: Jan supports Deepseek model roadmap: Jan supports Deepseek Distilled Models Jan 22, 2025
@dan-menlo dan-menlo changed the title roadmap: Jan supports Deepseek Distilled Models roadmap: Jan supports Deepseek Distilled Models for v0.5.14 Jan 22, 2025
@imtuyethan imtuyethan moved this from QA to Completed in Menlo Jan 23, 2025
@github-project-automation github-project-automation bot moved this from In Progress to QA in Menlo Jan 23, 2025
@olimart
Copy link

olimart commented Jan 23, 2025

hi, thanks your work.
do you mind sharing how to set up Deepseek R1 through Llama.cpp ?
It seems that Llama.cpp supports Deepseek models (at least could not find any blocker) but not sure how to get started.

I tried to import straight from the hub but looks like Deepseek R1 is not a GGUF model. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: model support Support new model, or fix broken model P1: important Important feature / fix type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

3 participants