Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: OpenAI O1 model requires max_completion_tokens parameter and custom model.json not loading #4443

Closed
3 tasks done
imtuyethan opened this issue Jan 13, 2025 · 3 comments
Closed
3 tasks done
Assignees
Labels
category: model support Support new model, or fix broken model type: bug Something isn't working
Milestone

Comments

@imtuyethan
Copy link
Contributor

Jan version

0.5.13

Describe the Bug

Two related issues:

  1. When using OpenAI O1 model settings in Jan, an error occurs requiring max_completion_tokens as a setting. This appears to affect all O1 models including preview and mini variants.

  2. Custom model.json files placed in AppData\Roaming\Jan\data\models\ folder are not being read by Jan. The app attempts to lock the folders but doesn't recognize the custom model.json files.

Steps to Reproduce

  1. Configure Jan to use OpenAI O1 model
  2. Attempt to run the model -> Receive error about max_completion_tokens requirement
  3. Create custom model.json file with O1 settings
  4. Place file in AppData\Roaming\Jan\data\models\
  5. Restart Jan -> Custom model.json not detected

Screenshots / Logs

https://discord.com/channels/1107178041848909847/1327701677813399705

What is your OS?

  • MacOS
  • Windows
  • Linux
@imtuyethan imtuyethan added the type: bug Something isn't working label Jan 13, 2025
@github-project-automation github-project-automation bot moved this to Investigating in Menlo Jan 13, 2025
@imtuyethan imtuyethan moved this from Investigating to Scheduled in Menlo Jan 13, 2025
@imtuyethan imtuyethan added this to the v0.5.14 milestone Jan 13, 2025
@imtuyethan imtuyethan added the category: model support Support new model, or fix broken model label Jan 13, 2025
@louis-menlo
Copy link
Contributor

Scoped in #3786

@louis-menlo
Copy link
Contributor

Issue 2: Won't be fixed. The GUI should support adding a model.

@louis-menlo louis-menlo moved this from Scheduled to Eng Review in Menlo Jan 14, 2025
@louis-menlo louis-menlo moved this from Eng Review to QA in Menlo Jan 15, 2025
@louis-menlo
Copy link
Contributor

Update:

This error wont be displayed with the latest fix, since engine request transform template already filtered out unsupported parameters

@imtuyethan imtuyethan moved this from QA to Completed in Menlo Jan 17, 2025
@imtuyethan imtuyethan modified the milestones: v0.5.14, v0.5.15 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: model support Support new model, or fix broken model type: bug Something isn't working
Projects
Status: Completed
Development

No branches or pull requests

2 participants