fix: empty response on some generation attempts #4454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request aims to resolve the issue of including the latest assistant response in the resend of recent chat messages, which disrupts the context. There are two main problems with this:
Fixes Issues
Changes
This pull request includes changes to the
useSendChatMessage
function in theweb/hooks/useSendChatMessage.ts
file to enhance the message sending process. The most important changes include adding new conversation data to thesendChatMessage
call and refactoring the message request building logic.Enhancements to message sending:
web/hooks/useSendChatMessage.ts
: AddednewConvoData
parameter to thesendChatMessage
call to include new conversation data when sending a message.Refactoring:
web/hooks/useSendChatMessage.ts
: Moved the conditionif (!isResend)
to a later point in the function to ensure that the message request is always built before checking if it is a resend. [1] [2]