Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Remove dangling Vercel call #3211

Closed
1 of 4 tasks
freelerobot opened this issue Jul 28, 2024 · 6 comments
Closed
1 of 4 tasks

bug: Remove dangling Vercel call #3211

freelerobot opened this issue Jul 28, 2024 · 6 comments
Assignees
@Van-QA
Labels
P0: critical Mission critical type: bug Something isn't working

Comments

@freelerobot
Copy link
Contributor

freelerobot commented Jul 28, 2024 •
edited
Loading

  • I have searched the existing issues

Current behavior

Jan app is making external calls to Vercel for some reason. Likely due to a previous feature that we have since deprecated. Let's remove it asap

Minimum reproduction step

  1. open app, interact
  2. watch networking io

Expected behavior

no vercel calls

Screenshots / Logs

https://x.com/levelsio/status/1817388406789243118

Jan version

assume latest?

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Environment details

No response
@freelerobot freelerobot added the type: bug Something isn't working label Jul 28, 2024
@freelerobot freelerobot added the P0: critical Mission critical label Jul 28, 2024
@namchuai
Copy link
Collaborator

I'm investigating this issue.
Below's the requests popup from app Little snitch when open jan. I'm not
Screenshot 2024-07-29 at 16 21 44

Screenshot 2024-07-29 at 16 22 23

downloading model from jan hub
Screenshot 2024-07-29 at 16 22 54
Screenshot 2024-07-29 at 16 24 34

@namchuai
Copy link
Collaborator

namchuai commented Jul 29, 2024 •
edited
Loading

My only 4 rules when download and running a model using Jan v0.5.2. And we don't have any specific code calling to vercel.

Screenshot 2024-07-29 at 16 39 46

@namchuai
Copy link
Collaborator

We removed Umami from PR #3221

@namchuai namchuai moved this to QA in Menlo Aug 8, 2024
@namchuai
Copy link
Collaborator

namchuai commented Aug 8, 2024

This should be fixed since we removed Umami. Still need to re-validate after Jan x Cortex release though.

@namchuai namchuai assigned Van-QA and unassigned namchuai Aug 13, 2024
@namchuai
Copy link
Collaborator

@Van-QA please help to verify. The app user is using is called Little Snitch.

@Van-QA Van-QA closed this as completed Aug 13, 2024
@github-project-automation github-project-automation bot moved this from QA to Done in Menlo Aug 13, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Aug 13, 2024

Feel free to reopen if the issue persist, thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Van-QA Van-QA

Labels
P0: critical Mission critical type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@namchuai @Van-QA @freelerobot