Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: threads lose titles on rename #3116

Closed
3 of 4 tasks
bogorad opened this issue Jun 28, 2024 · 4 comments
Closed
3 of 4 tasks

bug: threads lose titles on rename #3116

bogorad opened this issue Jun 28, 2024 · 4 comments
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@bogorad
Copy link

bogorad commented Jun 28, 2024

  • I have searched the existing issues

Current behavior

a thread which title has previously been changed, reverts to unnamed ("new thread", later auto-renamed based on content), when cleaned.

Minimum reproduction step

  1. create a new thread
  2. rename it to "something" via kebab-menu
  3. clean thread via kebab-menu

Expected behavior

the name "something" should stick, but instead it resets to "new thread".

Screenshots / Logs

n/a

Jan version

0.5.1

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Environment details

Win10 or Fedora-40, i5, 64 GiB RAM.

@bogorad bogorad added the type: bug Something isn't working label Jun 28, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Jun 30, 2024

Hi @bogorad, when cleaning any thread, we are expecting all details of the thread to be gone, including the thread title.
Feel free to add more context/reopen the ticket if needed.
For now, this is the correct behavior of the clean thread function

@Van-QA Van-QA closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2024
@github-project-automation github-project-automation bot moved this to Done in Menlo Jun 30, 2024
@bogorad
Copy link
Author

bogorad commented Jun 30, 2024

This is incorrect! When after clearing, you edit it, the old name of the thread reappears.

@Van-QA Van-QA reopened this Jul 1, 2024
@Van-QA Van-QA moved this from Done to Planned in Menlo Jul 1, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Jul 1, 2024

thank you, i‌t's reproducible:
image
Steps:

  1. U‌‌pda‌te thread name
  2. Clean threa‌d
  3. E‌dit the thread name again, and see the popup value i‌s ‌still using the thread name from No. 1 ❌

@urmauur urmauur moved this from Planned to In Progress in Menlo Jul 8, 2024
@urmauur urmauur moved this from In Progress to In Review in Menlo Jul 8, 2024
@urmauur urmauur moved this from In Review to QA in Menlo Jul 12, 2024
@Van-QA Van-QA closed this as completed Aug 5, 2024
@Van-QA Van-QA reopened this Aug 5, 2024
@Van-QA Van-QA added this to the v.0.6.0 milestone Aug 5, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Aug 5, 2024

@urmauur the issue is still happen on latest Jan x Cortex

@Van-QA Van-QA moved this from QA to In Progress in Menlo Aug 6, 2024
@Van-QA Van-QA modified the milestones: v.0.6.0, v.0.7.0 Aug 14, 2024
@Van-QA Van-QA closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants