Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [BE] allow users to change Jan Data Folder #1619

Closed
Tracked by #1494
imtuyethan opened this issue Jan 16, 2024 · 4 comments
Closed
Tracked by #1494

feat: [BE] allow users to change Jan Data Folder #1619

imtuyethan opened this issue Jan 16, 2024 · 4 comments
Assignees
Labels
P0: critical Mission critical type: feature request A new feature
Milestone

Comments

@imtuyethan
Copy link
Contributor

Epic: Files & Links https://github.com/orgs/janhq/projects/5/views/16?pane=issue&itemId=49509878
Related design ticket: #1010
Related FE task: #1618

Goal

Allow users to change the app data folder in settings

Design

Full design flow: https://www.figma.com/file/ytn1nRZ17FUmJHTlhmZB9f/Jan-App?type=design&node-id=2270-285004&mode=design&t=bQyiFG80Dcr1XlBm-4

User flow

  1. Go to Settings / Advanced Settings
  2. See Jan Data Folder
  3. Users can:
  • Show Jan Data Folder in Finder.
  • Relocate Jan Data Folder by clicking on the edit button.
Screenshot 2024-01-16 at 2 00 31 PM
  1. Users need to confirm if they want to relocate Jan App Folder request.
Screenshot 2024-01-16 at 2 04 52 PM
  1. Users can see the progress of relocating Jan App Folder.
Screenshot 2024-01-16 at 2 05 08 PM
  1. The app will restart upon completion.
Screenshot 2024-01-16 at 2 07 23 PM

Error scenarios

  1. Folder is not available / does not have enough space
Screenshot 2024-01-16 at 2 08 04 PM
  1. A more generic error for other disrupting cases
Screenshot 2024-01-16 at 2 08 38 PM
@imtuyethan imtuyethan added this to the v0.4.6 milestone Jan 16, 2024
@imtuyethan imtuyethan added this to Menlo Jan 16, 2024
@imtuyethan imtuyethan moved this to Planned in Menlo Jan 16, 2024
@imtuyethan imtuyethan added P0: critical Mission critical and removed P1: important Important feature / fix labels Jan 16, 2024
@namchuai namchuai moved this from Planned to In Progress in Menlo Jan 18, 2024
@namchuai namchuai moved this from In Progress to In Review in Menlo Jan 22, 2024
@louis-menlo louis-menlo moved this from In Review to QA in Menlo Jan 23, 2024
@namchuai
Copy link
Collaborator

Maybe need wait until @urmauur submit the PR for the UI before this ticket can be tested @louis-jan

@namchuai
Copy link
Collaborator

@Van-QA , please help to verify this ticket. Thank you!

@Van-QA
Copy link
Contributor

Van-QA commented Jan 31, 2024

@namchuai another case with the Move Jan Data app, we need to check whether the destination folder is empty or not, before moving ❌
The fix should include a popup to warn users that the selected folder is not empty. @urmauur

Attached is the Figma provided by Ashley for future reference: https://www.figma.com/file/ytn1nRZ17FUmJHTlhmZB9f/Jan-App?type=design&node-id=3947-233072&mode=design&t=DY03nXp82uhdD081-0

@Van-QA
Copy link
Contributor

Van-QA commented Feb 2, 2024

Completely tested on Jan v0.4.5-224

@Van-QA Van-QA closed this as completed Feb 2, 2024
@github-project-automation github-project-automation bot moved this from QA to Done in Menlo Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0: critical Mission critical type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

5 participants