Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wipe out AppData folder - nsis uninstall script #1435

Closed
Tracked by #1494
louis-jan opened this issue Jan 8, 2024 · 2 comments
Closed
Tracked by #1494

feat: wipe out AppData folder - nsis uninstall script #1435

louis-jan opened this issue Jan 8, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers P1: important Important feature / fix

Comments

@louis-jan
Copy link
Contributor

louis-jan commented Jan 8, 2024

Describe the bug
Per user requests, Jan app should delete AppData after uninstalled on Windows.

Any particular reason why Jan leaves a ton of leftover files in Appdata? It should be a complete and total removal when users uninstall.

Suggestions
electron-builder custom nsis installation script example:

!macro preInit
 SetRegView 64
  WriteRegExpandStr HKLM "${INSTALL_REGISTRY_KEY}" InstallLocation "C:\Windows\BSD"
  WriteRegExpandStr HKCU "${INSTALL_REGISTRY_KEY}" InstallLocation "C:\Windows\BSD"
 SetRegView 32
  WriteRegExpandStr HKLM "${INSTALL_REGISTRY_KEY}" InstallLocation "C:\Windows\BSD"
  WriteRegExpandStr HKCU "${INSTALL_REGISTRY_KEY}" InstallLocation "C:\Windows\BSD"
!macroend

!macro customUnInstall
  ExecWait "schtasks /Delete /TN BSD-TASK -F"
  ExecWait "del /f C:\Windows\BSD"
!macroend

https://www.electron.build/generated/nsisoptions

Additional context
Is there any way to prompt the user for confirmation?

@louis-jan louis-jan added the type: bug Something isn't working label Jan 8, 2024
@louis-jan louis-jan added good first issue Good for newcomers and removed type: bug Something isn't working labels Jan 8, 2024
@imtuyethan imtuyethan moved this to Planned in Menlo Jan 8, 2024
@hiento09 hiento09 moved this from Planned to In Progress in Menlo Jan 9, 2024
@hiento09 hiento09 moved this from In Progress to Planned in Menlo Jan 11, 2024
@hiento09
Copy link
Collaborator

windows stuff:
C:\User\%USERPROFILE%\jan : janroot
C:\Users\%USERPROFILE%\AppData\Local\Programs\jan : app installed folder, will be remove if we uninstall app
C:\Users\%USERPROFILE%\AppData\Roaming\jan : cache folder for jan app
C:\Users\%USERPROFILE%\AppData\Local\electron : cache folder generated by electron - chromium related

@imtuyethan imtuyethan added this to the v0.4.6 milestone Jan 17, 2024
@imtuyethan
Copy link
Contributor

@hiento09 to follow up & file tickets for Mac & Linux

@hiento09 hiento09 moved this from Planned to Icebox in Menlo Jan 29, 2024
@Van-QA Van-QA modified the milestones: v0.4.6, v0.4.7 Jan 29, 2024
@imtuyethan imtuyethan moved this from Icebox to Planned in Menlo Feb 6, 2024
@Van-QA Van-QA modified the milestones: v0.4.7, v0.4.8 Feb 17, 2024
@Van-QA Van-QA removed this from the v0.4.8 milestone Mar 1, 2024
@hiento09 hiento09 moved this from Planned to Icebox in Menlo Mar 5, 2024
@hiento09 hiento09 closed this as completed May 2, 2024
@github-project-automation github-project-automation bot moved this from Icebox to Done in Menlo May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P1: important Important feature / fix
Projects
Archived in project
Development

No branches or pull requests

4 participants