Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cortex serve attached mode outputs nothing #727

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix: cortex serve attached mode outputs nothing #727

merged 1 commit into from
Jun 18, 2024

Conversation

louis-menlo
Copy link
Contributor

Describe Your Changes

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-menlo louis-menlo requested a review from Van-QA June 18, 2024 14:07
Van-QA
Van-QA approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@Van-QA Van-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA Van-QA merged commit 09e9c4b into dev Jun 18, 2024
1 check passed
@Van-QA Van-QA deleted the fix/cortex-serve-detached branch June 18, 2024 14:14
cahyosubroto pushed a commit that referenced this pull request Jun 26, 2024
@louis-menlo @irfanpena
fix: cortex serve attached mode outputs nothing (#727)
4d6c1ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Van-QA Van-QA Van-QA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-menlo @Van-QA