Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Set dll libraries search path for Cortex on Windows #1047

Closed
Tracked by #1072
vansangpfiev opened this issue Aug 29, 2024 · 1 comment · Fixed by #982
Closed
Tracked by #1072

feat: Set dll libraries search path for Cortex on Windows #1047

vansangpfiev opened this issue Aug 29, 2024 · 1 comment · Fixed by #982
Assignees
@vansangpfiev
Labels
category: engine management Related to engine abstraction os: Windows P1: important Important feature / fix

Comments

@vansangpfiev
Copy link
Contributor

Our current approach is copy all .dll files into execution folder. We support multiple engines and if we keep dll files in engines/cortex.xxx folder, it seems cleaner. Should consider to find a solution to set dll search path.
@vansangpfiev vansangpfiev self-assigned this Aug 29, 2024
This was referenced Aug 29, 2024
Closed
Merged
@imtuyethan imtuyethan moved this to Icebox in Menlo Aug 30, 2024
@imtuyethan imtuyethan moved this from Icebox to Planning in Menlo Sep 2, 2024
@imtuyethan imtuyethan changed the title Set dll libraries search path for cortex on Windows feat: Set dll libraries search path for Cortex on Windows Sep 2, 2024
@vansangpfiev vansangpfiev moved this from Planning to Scheduled in Menlo Sep 4, 2024
@freelerobot
Copy link
Contributor

related disc: #1117

@freelerobot freelerobot added P1: important Important feature / fix category: engine management Related to engine abstraction os: Windows labels Sep 6, 2024
@vansangpfiev vansangpfiev moved this from Scheduled to In Progress in Menlo Sep 10, 2024
@github-project-automation github-project-automation bot moved this from In Review to Completed in Menlo Sep 12, 2024
@namchuai namchuai mentioned this issue Sep 12, 2024
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vansangpfiev vansangpfiev

Labels
category: engine management Related to engine abstraction os: Windows P1: important Important feature / fix
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add dll search path janhq/cortex.cpp
4 participants
@vansangpfiev @freelerobot and others