From 5fe057060982e8dc259f40b7ba3db4f38bba594e Mon Sep 17 00:00:00 2001 From: Louis Le Date: Fri, 5 Jul 2024 10:59:08 +0700 Subject: [PATCH 1/3] chore: #754 - add help information into root commands --- .../src/infrastructure/commanders/configs.command.ts | 8 +++----- .../src/infrastructure/commanders/engines.command.ts | 4 +++- cortex-js/src/infrastructure/commanders/models.command.ts | 4 +++- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/cortex-js/src/infrastructure/commanders/configs.command.ts b/cortex-js/src/infrastructure/commanders/configs.command.ts index 01f797b1a..c7e841ac2 100644 --- a/cortex-js/src/infrastructure/commanders/configs.command.ts +++ b/cortex-js/src/infrastructure/commanders/configs.command.ts @@ -8,11 +8,7 @@ import { ConfigsSetCommand } from './configs/configs-set.command'; @SubCommand({ name: 'configs', description: 'Get cortex configurations', - arguments: '', subCommands: [ConfigsGetCommand, ConfigsListCommand, ConfigsSetCommand], - argsDescription: { - name: 'Configuration name to get', - }, }) @SetCommandContext() export class ConfigsCommand extends CommandRunner { @@ -20,5 +16,7 @@ export class ConfigsCommand extends CommandRunner { super(); } - async run(): Promise {} + async run(): Promise { + this.command?.help(); + } } diff --git a/cortex-js/src/infrastructure/commanders/engines.command.ts b/cortex-js/src/infrastructure/commanders/engines.command.ts index f88f2a421..0209d309a 100644 --- a/cortex-js/src/infrastructure/commanders/engines.command.ts +++ b/cortex-js/src/infrastructure/commanders/engines.command.ts @@ -16,5 +16,7 @@ export class EnginesCommand extends CommandRunner { super(); } - async run(): Promise {} + async run(): Promise { + this.command?.help(); + } } diff --git a/cortex-js/src/infrastructure/commanders/models.command.ts b/cortex-js/src/infrastructure/commanders/models.command.ts index 17af50c0f..d59f387a1 100644 --- a/cortex-js/src/infrastructure/commanders/models.command.ts +++ b/cortex-js/src/infrastructure/commanders/models.command.ts @@ -23,5 +23,7 @@ import { RunCommand } from './shortcuts/run.command'; description: 'Subcommands for managing models', }) export class ModelsCommand extends CommandRunner { - async run(): Promise {} + async run(): Promise { + this.command?.help(); + } } From 5ef0eb990969e891e9639061ee3dc9d047191450 Mon Sep 17 00:00:00 2001 From: Louis Le Date: Fri, 5 Jul 2024 11:29:06 +0700 Subject: [PATCH 2/3] fix: add model name --- .../src/infrastructure/commanders/models/model-list.command.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/cortex-js/src/infrastructure/commanders/models/model-list.command.ts b/cortex-js/src/infrastructure/commanders/models/model-list.command.ts index e7e505106..369ed496d 100644 --- a/cortex-js/src/infrastructure/commanders/models/model-list.command.ts +++ b/cortex-js/src/infrastructure/commanders/models/model-list.command.ts @@ -22,6 +22,7 @@ export class ModelListCommand extends CommandRunner { ? console.table( models.map((e) => ({ id: e.model, + name: e.name, engine: e.engine, version: e.version, })), From 3c0e945d3c95e39df0bbb8350172bcd31388acbc Mon Sep 17 00:00:00 2001 From: Louis Le Date: Fri, 5 Jul 2024 11:39:46 +0700 Subject: [PATCH 3/3] fix: broken markdown link - build from source --- cortex-cpp/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cortex-cpp/README.md b/cortex-cpp/README.md index 61e9c2807..192e95612 100644 --- a/cortex-cpp/README.md +++ b/cortex-cpp/README.md @@ -163,7 +163,7 @@ Below is the available list of the model parameters you can set when loading a m ## Manual Build -Manual build is a process in which the developers build the software manually. This is usually done when a new feature is implemented, or a bug is fixed. The process for this project is defined in [`.github/workflows/build.yml`](.github/workflows/build.yml) +Manual build is a process in which the developers build the software manually. This is usually done when a new feature is implemented, or a bug is fixed. The process for this project is defined in [`.github/workflows/cortex-build.yml`](../.github/workflows/cortex-build.yml) ## Contact Support