Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: macos network installer not install llama-cpp engines by default #1616

Closed
hiento09 opened this issue Nov 4, 2024 · 6 comments
Closed
Assignees
Labels
P0: critical Mission critical type: bug Something isn't working
Milestone

Comments

@hiento09
Copy link
Contributor

hiento09 commented Nov 4, 2024

Context

  • From nightly version v1.0.0-191, cortex-install on macos not install llama-cpp engine by default

Goal

  • Fix the bug
  • Add e2e testing for installer
@hiento09 hiento09 added this to Menlo Nov 4, 2024
@hiento09 hiento09 self-assigned this Nov 4, 2024
@hiento09 hiento09 converted this from a draft issue Nov 4, 2024
@hiento09 hiento09 added P0: critical Mission critical type: bug Something isn't working labels Nov 4, 2024
@hiento09
Copy link
Contributor Author

hiento09 commented Nov 4, 2024

Thanks @vansangpfiev for finding out this bug

@gabrielle-ong gabrielle-ong moved this from In Review to Review + QA in Menlo Nov 6, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.2 milestone Nov 6, 2024
@gabrielle-ong
Copy link
Contributor

Hi @hiento09, I tried on v223 mac network installer

  • seems that llama-cpp engine is not installed, am I missing something?

Steps:
uninstalled engines, uninstalled cortex-nightly, reinstalled cortex-nightly
Image

@hiento09 hiento09 mentioned this issue Nov 6, 2024
3 tasks
@gabrielle-ong
Copy link
Contributor

Thanks @hiento09! Sorry I'm still not getting it on install on the v227 network installer

  • to confirm, llama-cpp should be listed in engines list upon install right?
  • it does successfully pull llama-cpp on cortex run
image

@hiento09
Copy link
Contributor Author

hiento09 commented Nov 7, 2024

Hi @gabrielle-ong , can you help test version 226? Version 226 was built from my branch for testing and has not been merged into the dev branch. Version 227 is the nightly version from yesterday and does not include my fix PR.

@gabrielle-ong
Copy link
Contributor

gabrielle-ong commented Nov 7, 2024

Adding the logs for future reference - thanks @hiento09 for investigating. tested v226 -

  1. Works on VM (test-macos-13-1)
  2. Doesnt work on my local mac - /var/log/install.log attached
    cortex-installer.log

@gabrielle-ong
Copy link
Contributor

tested on v228 for branch feat/cicd-docker, works on my local now. Thanks @hiento09!
image

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Nov 7, 2024
@gabrielle-ong gabrielle-ong modified the milestones: v1.0.2, v1.0.3 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0: critical Mission critical type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants