Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: check new update hang if network is down #1350

Closed
3 of 6 tasks
Tracked by #1087
vansangpfiev opened this issue Sep 27, 2024 · 2 comments · Fixed by #1352
Closed
3 of 6 tasks
Tracked by #1087

bug: check new update hang if network is down #1350

vansangpfiev opened this issue Sep 27, 2024 · 2 comments · Fixed by #1352
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@vansangpfiev
Copy link
Contributor

Cortex version

v0.5.0-120

Describe the Bug

Check new update for will be hanged if network is down

Steps to Reproduce

run cortex -v

Screenshots / Logs

No response

What is your OS?

  • MacOS
  • Windows
  • Linux

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)
@vansangpfiev vansangpfiev added the type: bug Something isn't working label Sep 27, 2024
@vansangpfiev vansangpfiev self-assigned this Sep 27, 2024
@dan-menlo dan-menlo added this to Menlo Sep 27, 2024
@github-project-automation github-project-automation bot moved this to Triage in Menlo Sep 27, 2024
@dan-menlo dan-menlo moved this from Triage to Scheduled in Menlo Sep 29, 2024
@vansangpfiev vansangpfiev moved this from Scheduled to In Progress in Menlo Sep 30, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Review + QA in Menlo Sep 30, 2024
@gabrielle-ong
Copy link
Contributor

Image

@vansangpfiev is this what we expect for this issue?

  • Y Doesnt hang
  • But errors something went wrong cannot copy file (this shouldnt be triggered)

@vansangpfiev
Copy link
Contributor Author

vansangpfiev commented Oct 2, 2024

@gabrielle-ong It is expected, because the download binary does not exist.
However, it can be improved, we should not try to update binary if download failed.

Update: the download binary does exist but it is empty, so the logic is correct in this case.

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Oct 3, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants