Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: models delete with new model folder structure #1320

Closed
Tracked by #1154
vansangpfiev opened this issue Sep 24, 2024 · 3 comments
Closed
Tracked by #1154

feat: models delete with new model folder structure #1320

vansangpfiev opened this issue Sep 24, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@vansangpfiev
Copy link
Contributor

vansangpfiev commented Sep 24, 2024

fixes #1154

@vansangpfiev vansangpfiev self-assigned this Sep 24, 2024
@freelerobot freelerobot moved this to In Progress in Menlo Sep 24, 2024
@freelerobot freelerobot added the type: feature request A new feature label Sep 24, 2024
@vansangpfiev vansangpfiev moved this from In Progress to In Review in Menlo Sep 24, 2024
@dan-menlo dan-menlo moved this from In Review to Review + QA in Menlo Sep 29, 2024
@gabrielle-ong
Copy link
Contributor

gabrielle-ong commented Sep 30, 2024

@sangjanai Edited:
Qn: Do we expect to delete the folder that contains the .gguf and .yml file?

  • If there are multiple models in the same folder (when is this the case?) - then we want to delete the files but not the folder

1.cortex models delete tinyllama
2. ✅ cortex models list doesnt have deleted model
3. ❌ .gguf and .yml file is deleted, but not the parent folder eg 1b-gguf
Image

@vansangpfiev
Copy link
Contributor Author

We do not delete model folder because we can have several models in the same directory.
image
@gabrielle-ong

@gabrielle-ong
Copy link
Contributor

Noted. Ok, marking as closed, .gguf and .yml files deleted as expected
QA: Windows, Mac, Ubuntu

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Oct 2, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants